Add support for custom properties and @apply when iterating InlineStylePropertyMap

Add support for custom properties and @apply when iterating InlineStylePropertyMap

This should prevent crashes when a custom property is set on
an element.

BUG=619010
Committed: https://crrev.com/7e1e6ff72cd56eb5c6bbbf741ceff1c1ccee186f
Cr-Commit-Position: refs/heads/master@{#403747}

[meade_UTC10, 2016-06-30 20:50:49]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-06-30 20:50:50]

Tim: I wasn't really sure how to test the @apply thing from JS - is there a way
to do that yet?

[Timothy Loh, 2016-07-01 00:57:11]

You should be able to set @apply rules with something like

e.style.cssText = "@apply --foo"

https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:159:
value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration->customCSSText()));
I just checked the impl and it looks like it isn't handling initial/etc yet,
maybe add a TODO so we don't forget (I guess here we'll want to be returning a
CSSKeywordValue anyway)

[meade_UTC10, 2016-07-05 00:45:29]

https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:159:
value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration->customCSSText()));
On 2016/07/01 00:57:11, Timothy Loh wrote:
> I just checked the impl and it looks like it isn't handling initial/etc yet,
> maybe add a TODO so we don't forget (I guess here we'll want to be returning a
> CSSKeywordValue anyway)

Done.

[Timothy Loh, 2016-07-05 05:34:39]

On 2016/07/05 00:45:29, Eddy wrote:
>
https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
> (right):
> 
>
https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:159:
>
value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration->customCSSText()));
> On 2016/07/01 00:57:11, Timothy Loh wrote:
> > I just checked the impl and it looks like it isn't handling initial/etc yet,
> > maybe add a TODO so we don't forget (I guess here we'll want to be returning
a
> > CSSKeywordValue anyway)
> 
> Done.

lgtm

[meade_UTC10, 2016-07-05 07:03:06]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2016-07-05 07:03:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 07:07:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-05 07:08:56]

Description was changed from

==========
Add support for custom properties and @apply when iterating
InlineStylePropertyMap

This should prevent crashes when a custom property is set on
an element.

BUG=619010
==========

to

==========
Add support for custom properties and @apply when iterating
InlineStylePropertyMap

This should prevent crashes when a custom property is set on
an element.

BUG=619010

Committed: https://crrev.com/7e1e6ff72cd56eb5c6bbbf741ceff1c1ccee186f
Cr-Commit-Position: refs/heads/master@{#403747}
==========

[commit-bot: I haz the power, 2016-07-05 07:08:57]

Patchset 3 (id:??) landed as
https://crrev.com/7e1e6ff72cd56eb5c6bbbf741ceff1c1ccee186f
Cr-Commit-Position: refs/heads/master@{#403747}