Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2115673003: Add support for custom properties and @apply when iterating InlineStylePropertyMap (Closed)

Created:
4 years, 5 months ago by meade_UTC10
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for custom properties and @apply when iterating InlineStylePropertyMap This should prevent crashes when a custom property is set on an element. BUG=619010 Committed: https://crrev.com/7e1e6ff72cd56eb5c6bbbf741ceff1c1ccee186f Cr-Commit-Position: refs/heads/master@{#403747}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync to head #

Patch Set 3 : Add a test, add a todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 2 2 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
meade_UTC10
Tim: I wasn't really sure how to test the @apply thing from JS - is ...
4 years, 5 months ago (2016-06-30 20:50:50 UTC) #2
Timothy Loh
You should be able to set @apply rules with something like e.style.cssText = "@apply --foo" ...
4 years, 5 months ago (2016-07-01 00:57:11 UTC) #3
meade_UTC10
https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp (right): https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp#newcode159 third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:159: value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration->customCSSText())); On 2016/07/01 00:57:11, Timothy Loh wrote: > I ...
4 years, 5 months ago (2016-07-05 00:45:29 UTC) #4
Timothy Loh
On 2016/07/05 00:45:29, Eddy wrote: > https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp > File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp > (right): > > https://codereview.chromium.org/2115673003/diff/1/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp#newcode159 ...
4 years, 5 months ago (2016-07-05 05:34:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115673003/40001
4 years, 5 months ago (2016-07-05 07:03:23 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-05 07:07:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 07:08:57 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7e1e6ff72cd56eb5c6bbbf741ceff1c1ccee186f
Cr-Commit-Position: refs/heads/master@{#403747}

Powered by Google App Engine
This is Rietveld 408576698