Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Side by Side Diff: ash/common/focus_cycler.cc

Issue 2115663002: Folds methods in WmShellCommon to WmShell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/aura/wm_shell_aura.cc ('k') | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/focus_cycler.h" 5 #include "ash/common/focus_cycler.h"
6 6
7 #include "ash/common/wm/mru_window_tracker.h" 7 #include "ash/common/wm/mru_window_tracker.h"
8 #include "ash/common/wm/window_state.h" 8 #include "ash/common/wm/window_state.h"
9 #include "ash/common/wm_shell.h" 9 #include "ash/common/wm_shell.h"
10 #include "ash/common/wm_window.h" 10 #include "ash/common/wm_window.h"
11 #include "ui/views/accessible_pane_view.h" 11 #include "ui/views/accessible_pane_view.h"
12 #include "ui/views/focus/focus_search.h" 12 #include "ui/views/focus/focus_search.h"
13 #include "ui/views/widget/widget.h" 13 #include "ui/views/widget/widget.h"
14 #include "ui/wm/public/activation_client.h" 14 #include "ui/wm/public/activation_client.h"
15 15
16 namespace ash { 16 namespace ash {
17 17
18 namespace { 18 namespace {
19 19
20 bool HasFocusableWindow() { 20 bool HasFocusableWindow() {
21 return !WmShell::Get()->GetMruWindowTracker()->BuildMruWindowList().empty(); 21 return !WmShell::Get()->mru_window_tracker()->BuildMruWindowList().empty();
22 } 22 }
23 23
24 } // namespace 24 } // namespace
25 25
26 FocusCycler::FocusCycler() : widget_activating_(nullptr) {} 26 FocusCycler::FocusCycler() : widget_activating_(nullptr) {}
27 27
28 FocusCycler::~FocusCycler() {} 28 FocusCycler::~FocusCycler() {}
29 29
30 void FocusCycler::AddWidget(views::Widget* widget) { 30 void FocusCycler::AddWidget(views::Widget* widget) {
31 widgets_.push_back(widget); 31 widgets_.push_back(widget);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 else 73 else
74 index = ((index - 1) + count) % count; 74 index = ((index - 1) + count) % count;
75 75
76 // Ensure that we don't loop more than once. 76 // Ensure that we don't loop more than once.
77 if (index == start_index) 77 if (index == start_index)
78 break; 78 break;
79 79
80 if (index == browser_index) { 80 if (index == browser_index) {
81 // Activate the most recently active browser window. 81 // Activate the most recently active browser window.
82 MruWindowTracker::WindowList mru_windows( 82 MruWindowTracker::WindowList mru_windows(
83 WmShell::Get()->GetMruWindowTracker()->BuildMruWindowList()); 83 WmShell::Get()->mru_window_tracker()->BuildMruWindowList());
84 if (mru_windows.empty()) 84 if (mru_windows.empty())
85 break; 85 break;
86 WmWindow* window = mru_windows.front(); 86 WmWindow* window = mru_windows.front();
87 window->GetWindowState()->Activate(); 87 window->GetWindowState()->Activate();
88 views::Widget* widget = window->GetInternalWidget(); 88 views::Widget* widget = window->GetInternalWidget();
89 if (!widget) 89 if (!widget)
90 break; 90 break;
91 views::FocusManager* focus_manager = widget->GetFocusManager(); 91 views::FocusManager* focus_manager = widget->GetFocusManager();
92 focus_manager->ClearFocus(); 92 focus_manager->ClearFocus();
93 focus_manager->RotatePaneFocus(direction == BACKWARD 93 focus_manager->RotatePaneFocus(direction == BACKWARD
(...skipping 11 matching lines...) Expand all
105 bool FocusCycler::FocusWidget(views::Widget* widget) { 105 bool FocusCycler::FocusWidget(views::Widget* widget) {
106 // Note: It is not necessary to set the focus directly to the pane since that 106 // Note: It is not necessary to set the focus directly to the pane since that
107 // will be taken care of by the widget activation. 107 // will be taken care of by the widget activation.
108 widget_activating_ = widget; 108 widget_activating_ = widget;
109 widget->Activate(); 109 widget->Activate();
110 widget_activating_ = NULL; 110 widget_activating_ = NULL;
111 return widget->IsActive(); 111 return widget->IsActive();
112 } 112 }
113 113
114 } // namespace ash 114 } // namespace ash
OLDNEW
« no previous file with comments | « ash/aura/wm_shell_aura.cc ('k') | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698