Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2115623002: [tools/perf] Add system_health_smoke_test that run all system health stories (Reland) (Closed)

Created:
4 years, 5 months ago by nednguyen
Modified:
4 years, 5 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Add system_health_smoke_test that run all system health stories (Reland) *** NOTE TO SHERRIF *** If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* please do not revert this CL but instead disabling failing test by adding them into the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py 1st patch from issue 2110653002 at patchset 160001 (http://crrev.com/2110653002#ps160001) 2nd patch disable more tests BUG=615382 TBR=petrcermak@chromium.org Committed: https://crrev.com/ea61739c46e564f0c6651e376dd4d8d9e0a2d0df Cr-Commit-Position: refs/heads/master@{#403237}

Patch Set 1 #

Patch Set 2 : Disable more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -0 lines) Patch
A tools/perf/benchmarks/system_health_smoke_test.py View 1 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115623002/20001
4 years, 5 months ago (2016-06-30 17:15:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/96830)
4 years, 5 months ago (2016-06-30 18:09:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115623002/20001
4 years, 5 months ago (2016-06-30 18:10:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 19:06:00 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:06:04 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ea61739c46e564f0c6651e376dd4d8d9e0a2d0df Cr-Commit-Position: refs/heads/master@{#403237}
4 years, 5 months ago (2016-06-30 19:08:29 UTC) #17
petrcermak
4 years, 5 months ago (2016-06-30 22:32:25 UTC) #19
Message was sent while issue was closed.
LGTM. Thanks!

Petr

Powered by Google App Engine
This is Rietveld 408576698