Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/optimizing-compiler-thread.h

Issue 21156009: Re-revert "Flush parallel recompilation queues on context dispose notification" (r15883). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 #ifdef DEBUG 47 #ifdef DEBUG
48 thread_id_(0), 48 thread_id_(0),
49 thread_id_mutex_(OS::CreateMutex()), 49 thread_id_mutex_(OS::CreateMutex()),
50 #endif 50 #endif
51 isolate_(isolate), 51 isolate_(isolate),
52 stop_semaphore_(OS::CreateSemaphore(0)), 52 stop_semaphore_(OS::CreateSemaphore(0)),
53 input_queue_semaphore_(OS::CreateSemaphore(0)), 53 input_queue_semaphore_(OS::CreateSemaphore(0)),
54 install_mutex_(OS::CreateMutex()), 54 install_mutex_(OS::CreateMutex()),
55 time_spent_compiling_(0), 55 time_spent_compiling_(0),
56 time_spent_total_(0) { 56 time_spent_total_(0) {
57 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(CONTINUE)); 57 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
58 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0)); 58 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0));
59 } 59 }
60 60
61 void Run(); 61 void Run();
62 void Stop(); 62 void Stop();
63 void Flush(); 63 void CompileNext();
64 void QueueForOptimization(OptimizingCompiler* optimizing_compiler); 64 void QueueForOptimization(OptimizingCompiler* optimizing_compiler);
65 void InstallOptimizedFunctions(); 65 void InstallOptimizedFunctions();
66 66
67 inline bool IsQueueAvailable() { 67 inline bool IsQueueAvailable() {
68 // We don't need a barrier since we have a data dependency right 68 // We don't need a barrier since we have a data dependency right
69 // after. 69 // after.
70 Atomic32 current_length = NoBarrier_Load(&queue_length_); 70 Atomic32 current_length = NoBarrier_Load(&queue_length_);
71 71
72 // This can be queried only from the execution thread. 72 // This can be queried only from the execution thread.
73 ASSERT(!IsOptimizerThread()); 73 ASSERT(!IsOptimizerThread());
(...skipping 11 matching lines...) Expand all
85 ~OptimizingCompilerThread() { 85 ~OptimizingCompilerThread() {
86 delete install_mutex_; 86 delete install_mutex_;
87 delete input_queue_semaphore_; 87 delete input_queue_semaphore_;
88 delete stop_semaphore_; 88 delete stop_semaphore_;
89 #ifdef DEBUG 89 #ifdef DEBUG
90 delete thread_id_mutex_; 90 delete thread_id_mutex_;
91 #endif 91 #endif
92 } 92 }
93 93
94 private: 94 private:
95 enum StopFlag { CONTINUE, STOP, FLUSH };
96
97 void FlushQueue(UnboundQueue<OptimizingCompiler*>* queue,
98 bool restore_function_code);
99 void CompileNext();
100
101 #ifdef DEBUG 95 #ifdef DEBUG
102 int thread_id_; 96 int thread_id_;
103 Mutex* thread_id_mutex_; 97 Mutex* thread_id_mutex_;
104 #endif 98 #endif
105 99
106 Isolate* isolate_; 100 Isolate* isolate_;
107 Semaphore* stop_semaphore_; 101 Semaphore* stop_semaphore_;
108 Semaphore* input_queue_semaphore_; 102 Semaphore* input_queue_semaphore_;
109 UnboundQueue<OptimizingCompiler*> input_queue_; 103 UnboundQueue<OptimizingCompiler*> input_queue_;
110 UnboundQueue<OptimizingCompiler*> output_queue_; 104 UnboundQueue<OptimizingCompiler*> output_queue_;
111 Mutex* install_mutex_; 105 Mutex* install_mutex_;
112 volatile AtomicWord stop_thread_; 106 volatile AtomicWord stop_thread_;
113 volatile Atomic32 queue_length_; 107 volatile Atomic32 queue_length_;
114 int64_t time_spent_compiling_; 108 int64_t time_spent_compiling_;
115 int64_t time_spent_total_; 109 int64_t time_spent_total_;
116 }; 110 };
117 111
118 } } // namespace v8::internal 112 } } // namespace v8::internal
119 113
120 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_ 114 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698