Issue 21156005: Web Animations: Add an event delegate to allow different forms of event dispatch

Issue 21156005: Web Animations: Add an event delegate to allow different forms of event dispatch (Closed)

Created:
7 years, 4 months ago by dstockwell

Modified:
7 years, 4 months ago

Reviewers:
pdr.

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations: Add an event delegate to allow different forms of event dispatch Initially this will be used to support CSS Animation events. BUG=232278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155389

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -6 lines)			Patch
M	Source/core/animation/TimedItem.h	View	1	4 chunks	+9 lines, -1 line	0 comments	Download
M	Source/core/animation/TimedItem.cpp	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/core/animation/TimedItemTest.cpp	View		3 chunks	+71 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pdr.

Very reasonable. LGTM https://codereview.chromium.org/21156005/diff/1/Source/core/animation/Animation.cpp File Source/core/animation/Animation.cpp (right): https://codereview.chromium.org/21156005/diff/1/Source/core/animation/Animation.cpp#newcode46 Source/core/animation/Animation.cpp:46: : TimedItem(timing, nullptr) Would it be ...

7 years, 4 months ago (2013-08-01 21:11:16 UTC) #3

dstockwell

https://codereview.chromium.org/21156005/diff/1/Source/core/animation/Animation.cpp File Source/core/animation/Animation.cpp (right): https://codereview.chromium.org/21156005/diff/1/Source/core/animation/Animation.cpp#newcode46 Source/core/animation/Animation.cpp:46: : TimedItem(timing, nullptr) On 2013/08/01 21:11:16, pdr wrote: > ...

7 years, 4 months ago (2013-08-02 00:23:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/21156005/7001

7 years, 4 months ago (2013-08-02 00:25:05 UTC) #5

Message was sent while issue was closed.

Change committed as 155389

Expand Messages | Collapse Messages