Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 2115553002: sandwich: Fixes some failures in request_track.py (Closed)

Created:
4 years, 5 months ago by gabadie
Modified:
4 years, 5 months ago
Reviewers:
mattcary, blundell
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Fixes some failures in request_track.py This CL fixes the following failures in request_track.py: - Data protocol are known to have encodedDataLength == 0 - Some request_id might be duplicated and this CL just ignore the duplicated errors. BUG=623966 Committed: https://crrev.com/08ade9ccbfd03bcef642262243542f83bb6776e8 Cr-Commit-Position: refs/heads/master@{#403432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M tools/android/loading/request_track.py View 5 chunks +10 lines, -6 lines 0 comments Download
M tools/android/loading/request_track_unittest.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
gabadie
4 years, 5 months ago (2016-06-30 12:24:27 UTC) #2
mattcary
lgtm Thanks for adding tests!
4 years, 5 months ago (2016-06-30 13:48:19 UTC) #3
gabadie
Adding blundell. PTAL.
4 years, 5 months ago (2016-06-30 18:29:49 UTC) #5
blundell
lgtm
4 years, 5 months ago (2016-07-01 08:55:01 UTC) #6
gabadie
On 2016/07/01 08:55:01, blundell wrote: > lgtm Thanks Guys! Landing.
4 years, 5 months ago (2016-07-01 09:04:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115553002/1
4 years, 5 months ago (2016-07-01 09:05:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 10:03:10 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 10:05:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ade9ccbfd03bcef642262243542f83bb6776e8
Cr-Commit-Position: refs/heads/master@{#403432}

Powered by Google App Engine
This is Rietveld 408576698