Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2115543002: Revert of 🎊 Reland of Have build_config targets depend only on other build_config targets (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🎊 Reland of Have build_config targets depend only on other build_config targets (patchset #2 id:130001 of https://codereview.chromium.org/2109593005/ ) Reason for revert: breaks downstream rollers' gn gen Original issue's description: > Reland of Have build_config targets depend only on other build_config targets > > Reason for revert: > Added missing dep for andriod_assets. Testing clean builds. > > TBR=brettw > BUG=620034 > > Committed: https://crrev.com/3df1aa821cb0298158b788bb37087460a19e52ea > Cr-Commit-Position: refs/heads/master@{#403054} TBR=brettw@chromium.org,petewil@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620034 Committed: https://crrev.com/4cd3b19c9551a8f70842f732f289de3640b038ab Cr-Commit-Position: refs/heads/master@{#403140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -162 lines) Patch
M build/android/gyp/write_build_config.py View 2 chunks +12 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 9 chunks +20 lines, -115 lines 0 comments Download
M build/config/android/rules.gni View 12 chunks +20 lines, -41 lines 0 comments Download
M chromecast/browser/android/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
Created Revert of 🎊 Reland of Have build_config targets depend only on other build_config targets
4 years, 5 months ago (2016-06-30 11:44:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115543002/1
4 years, 5 months ago (2016-06-30 11:44:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 11:45:29 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 11:45:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4cd3b19c9551a8f70842f732f289de3640b038ab Cr-Commit-Position: refs/heads/master@{#403140}
4 years, 5 months ago (2016-06-30 11:47:01 UTC) #7
agrieve
4 years, 5 months ago (2016-06-30 13:32:24 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2109293003/ by agrieve@chromium.org.

The reason for reverting is: will fix x2.

Powered by Google App Engine
This is Rietveld 408576698