Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2115513002: [turbofan] Introduce CheckIf simplified operator. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CheckIf simplified operator. This adds a new CheckIf operator and changes all direct uses of DeoptimizeIf and DeoptimizeUnless on the JavaScript level to use CheckIf (or one of the more concrete check operators) instead. This way we do not depend on particular frame states, but the effect/control linearizer will assign an appropriate frame state instead. R=jarin@chromium.org BUG=v8:5141 Committed: https://crrev.com/483291d23082c013efbbe074e1475550ca8c55de Cr-Commit-Position: refs/heads/master@{#37423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -95 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/js-call-reducer.cc View 8 chunks +19 lines, -26 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 9 chunks +21 lines, -27 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/redundancy-elimination.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +20 lines, -25 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 3 chunks +16 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-30 08:00:24 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the CheckIf thingy. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-06-30 08:02:16 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-06-30 08:34:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115513002/1
4 years, 5 months ago (2016-06-30 08:36:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 08:39:56 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 08:41:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/483291d23082c013efbbe074e1475550ca8c55de
Cr-Commit-Position: refs/heads/master@{#37423}

Powered by Google App Engine
This is Rietveld 408576698