Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2115493005: Add some webapk source directories to eclise .classpath (Closed)

Created:
4 years, 5 months ago by Yaron
Modified:
4 years, 5 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some webapk source directories to eclise .classpath Committed: https://crrev.com/06abe9e0f846d32f5f5bcc6a670c494f9ca81eb6 Cr-Commit-Position: refs/heads/master@{#403241}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix order #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/android/eclipse/.classpath View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yaron
4 years, 5 months ago (2016-06-30 16:32:39 UTC) #2
Xi Han
Thanks for updating this file! https://codereview.chromium.org/2115493005/diff/1/tools/android/eclipse/.classpath File tools/android/eclipse/.classpath (right): https://codereview.chromium.org/2115493005/diff/1/tools/android/eclipse/.classpath#newcode33 tools/android/eclipse/.classpath:33: <classpathentry kind="src" path="chrome/android/webapk/libs/common/src"/> Move ...
4 years, 5 months ago (2016-06-30 16:39:17 UTC) #3
Yaron
https://codereview.chromium.org/2115493005/diff/1/tools/android/eclipse/.classpath File tools/android/eclipse/.classpath (right): https://codereview.chromium.org/2115493005/diff/1/tools/android/eclipse/.classpath#newcode33 tools/android/eclipse/.classpath:33: <classpathentry kind="src" path="chrome/android/webapk/libs/common/src"/> On 2016/06/30 16:39:16, Xi Han wrote: ...
4 years, 5 months ago (2016-06-30 16:41:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115493005/40001
4 years, 5 months ago (2016-06-30 16:41:53 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-30 16:41:54 UTC) #9
Xi Han
lgtm
4 years, 5 months ago (2016-06-30 17:17:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115493005/40001
4 years, 5 months ago (2016-06-30 18:07:40 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 19:09:41 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:12:47 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06abe9e0f846d32f5f5bcc6a670c494f9ca81eb6
Cr-Commit-Position: refs/heads/master@{#403241}

Powered by Google App Engine
This is Rietveld 408576698