Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2115493002: [builtins] Migrate Math.abs() to TurboFan builtins. (Closed)

Created:
4 years, 5 months ago by Franzi
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Math.abs() to TurboFan builtins. Like the other Math builtins, Math.abs() is now a TurboFan builtin. It uses RawMachineAssembler::Float64Abs(). R=bmeurer@chromium.org BUG=v8:5163, v8:5086 LOG=N Committed: https://crrev.com/203391bcc0e970d3cae27ba99afd337c1c5f6d42 Cr-Commit-Position: refs/heads/master@{#37433}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Resolve merge conflict #

Patch Set 4 : Add comment back in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/code-assembler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/math.js View 4 chunks +1 line, -12 lines 0 comments Download
M src/js/v8natives.js View 1 2 chunks +1 line, -5 lines 0 comments Download
M test/mjsunit/mirror-script.js View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-30 07:53:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115493002/30010
4 years, 5 months ago (2016-06-30 09:56:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:30010)
4 years, 5 months ago (2016-06-30 10:25:24 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 10:27:21 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/203391bcc0e970d3cae27ba99afd337c1c5f6d42
Cr-Commit-Position: refs/heads/master@{#37433}

Powered by Google App Engine
This is Rietveld 408576698