Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issue 2115483003: Revert of Fix MultibufferDataSource::GetSize (Closed)

Created:
4 years, 5 months ago by Geoff Lang
Modified:
4 years, 5 months ago
Reviewers:
hubbe, kostya-k
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix MultibufferDataSource::GetSize (patchset #1 id:1 of https://codereview.chromium.org/2110853006/ ) Reason for revert: I believe this CL is causing flakyness in the video related tests on the GPU FYI waterfall. Examples: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/25925 https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48492 https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/5019 Seeing this in the output log: [27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource [27562:34423:0630/083352:ERROR:ffmpeg_demuxer.cc(1510)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource [27562:1287:0630/083352:FATAL:resource_multibuffer_data_provider.cc(75)] Check failed: byte_pos() < url_data_->length() (32768 vs. 10292) http://127.0.0.1:53903/resources/red-green.theora.ogv Original issue's description: > Fix MultibufferDataSource::GetSize > > When file loading is finished ResourceMultiBufferDataProvider count > DataBuffer queue size twice, so GetSize returned incorrect value. > > BUG= > > Committed: https://crrev.com/bbaba3c8053a39f6d11d78a6e4770b37a9639067 > Cr-Commit-Position: refs/heads/master@{#403123} TBR=hubbe@chromium.org,kostya-k@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624853 Committed: https://crrev.com/b2271028e1934c5b9c607b75e31b27b195c18c6e Cr-Commit-Position: refs/heads/master@{#403211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Geoff Lang
Created Revert of Fix MultibufferDataSource::GetSize
4 years, 5 months ago (2016-06-30 17:40:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115483003/1
4 years, 5 months ago (2016-06-30 17:40:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:42:26 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:42:37 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:45:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2271028e1934c5b9c607b75e31b27b195c18c6e
Cr-Commit-Position: refs/heads/master@{#403211}

Powered by Google App Engine
This is Rietveld 408576698