Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2115453004: Add variations target to translate component in gyp. (Closed)

Created:
4 years, 5 months ago by baxley
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add variations target to translate component in gyp. In order to build translate_core_browser from projects built with gyp, variations is needed as a dependency. BUG= Committed: https://crrev.com/0fa42268fbd0b9c0a5249452ce64c3de80bb1e63 Cr-Commit-Position: refs/heads/master@{#403363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/translate.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kkhorimoto
lgtm
4 years, 5 months ago (2016-06-30 23:07:30 UTC) #2
groby-ooo-7-16
lgtm
4 years, 5 months ago (2016-06-30 23:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115453004/1
4 years, 5 months ago (2016-06-30 23:22:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 00:18:34 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:20:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fa42268fbd0b9c0a5249452ce64c3de80bb1e63
Cr-Commit-Position: refs/heads/master@{#403363}

Powered by Google App Engine
This is Rietveld 408576698