Use PostTask, not performSelector in NativeWidgetMac::Close()

Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
Committed: https://crrev.com/961644ad65fe2d43190d79e99f8b00a661026f6f
Cr-Commit-Position: refs/heads/master@{#403400}

[tapted, 2016-06-30 04:49:33]

Description was changed from

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff and when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close] in a block to
retain the window receiving the close.

BUG=624648
==========

to

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. Then, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close] in a block to
retain the window receiving the close.

BUG=624648
==========

[tapted, 2016-06-30 04:49:33]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2016-06-30 04:50:19]

Description was changed from

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. Then, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close] in a block to
retain the window receiving the close.

BUG=624648
==========

to

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. Then, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

[tapted, 2016-06-30 04:54:15]

Description was changed from

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. Then, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

to

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

[tapted, 2016-06-30 07:06:15]

Hi Robert, please take a look

[Robert Sesek, 2016-07-01 02:31:38]

LGTM

The main reason we use the -performSelector:… approach is that a posted task can
get pumped during nested run loops associated with -performClose: and
mouseDown:. Since Cocoa won't be spinning any such loops, this shouldn't result
in zombies or other reentrancy issues.

https://codereview.chromium.org/2115453002/diff/1/ui/views/widget/native_widg...
File ui/views/widget/native_widget_mac.mm (right):

https://codereview.chromium.org/2115453002/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac.mm:376:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, base::BindBlock(^() {
nit: just ^{ will work

[tapted, 2016-07-01 03:31:53]

Thanks Robert!

https://codereview.chromium.org/2115453002/diff/1/ui/views/widget/native_widg...
File ui/views/widget/native_widget_mac.mm (right):

https://codereview.chromium.org/2115453002/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac.mm:376:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, base::BindBlock(^() {
On 2016/07/01 02:31:38, Robert Sesek wrote:
> nit: just ^{ will work

Done.

[tapted, 2016-07-01 03:32:02]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-07-01 03:32:03]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2115453002/#ps20001
(title: "no parens")

[commit-bot: I haz the power, 2016-07-01 03:32:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 03:39:51]

Description was changed from

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

to

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

[commit-bot: I haz the power, 2016-07-01 03:39:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 03:42:20]

Description was changed from

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648
==========

to

==========
Use PostTask, not performSelector in NativeWidgetMac::Close()

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648

Committed: https://crrev.com/961644ad65fe2d43190d79e99f8b00a661026f6f
Cr-Commit-Position: refs/heads/master@{#403400}
==========

[commit-bot: I haz the power, 2016-07-01 03:42:21]

Patchset 2 (id:??) landed as
https://crrev.com/961644ad65fe2d43190d79e99f8b00a661026f6f
Cr-Commit-Position: refs/heads/master@{#403400}