chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm - Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm

Issue 2115433002: Ensure permission bubble is stacked below the exclusive access bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-bubble-detach-from-fullscreen

Patch Set: Fix Mac compile. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm ('k') | chrome/browser/ui/views/exclusive_access_bubble_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm

index 590b9039e7db8eb1b965771d58b4755c1cb1291d..d744343780515624350c9c63be9dee4e178cbe88 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_view_cocoa_views.mm

@@ -7,6 +7,7 @@

#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_window.h"

#import "chrome/browser/ui/cocoa/browser_window_controller.h"

+#include "chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h"

#import "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h"

#import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"

#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"

@@ -33,6 +34,12 @@ views::BubbleBorder::Arrow PermissionBubbleViewViews::GetAnchorArrow() {

: views::BubbleBorder::NONE;

}

+gfx::NativeView PermissionBubbleViewViews::GetExclusiveAccessNativeView() {

+ BrowserWindowController* controller = [BrowserWindowController

+ browserWindowControllerForWindow:browser_->window()->GetNativeWindow()];

+ return [controller exclusiveAccessController]->GetNativeView();

// static

std::unique_ptr<PermissionBubbleView> PermissionBubbleView::Create(

Browser* browser) {