Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: test/mjsunit/regress/regress-crbug-625547.js

Issue 2115413002: [crankshaft] Use canonical nan_value or minus_zero_value objects instead of constant heap numbers w… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-crbug-625547.js
diff --git a/test/mjsunit/regress/regress-crbug-617567.js b/test/mjsunit/regress/regress-crbug-625547.js
similarity index 55%
copy from test/mjsunit/regress/regress-crbug-617567.js
copy to test/mjsunit/regress/regress-crbug-625547.js
index f0c696e14b205c8094bb04f909b43a2677bf4c26..20eb85db5e3c4e06746356e9410e934b547e827c 100644
--- a/test/mjsunit/regress/regress-crbug-617567.js
+++ b/test/mjsunit/regress/regress-crbug-625547.js
@@ -2,23 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --turbo-filter=* --allow-natives-syntax
+// Flags: --allow-natives-syntax --expose-gc
var v1 = {};
-function g() {
- v1 = [];
- for (var i = 0; i < 1; i++) {
- v1[i]();
- }
-}
-
+v1 = 0;
var v2 = {};
-var v3 = {};
-function f() {
- v3 = v2;
- g();
-}
+v2 = 0;
+gc();
-assertThrows(g);
+var minus_zero = {z:-0.0}.z;
+var nan = undefined + 1;
+function f() {
+ v1 = minus_zero;
+ v2 = nan;
+};
%OptimizeFunctionOnNextCall(f);
-assertThrows(f);
+f();
+gc(); // Boom!
« no previous file with comments | « src/crankshaft/hydrogen-instructions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698