Issue 2115413002: [crankshaft] Use canonical nan_value or minus_zero_value objects instead of constant heap numbers w…

Issue 2115413002: [crankshaft] Use canonical nan_value or minus_zero_value objects instead of constant heap numbers w… (Closed)

Created:
4 years, 5 months ago by Igor Sheludko

Modified:
4 years, 5 months ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[crankshaft] Use canonical nan_value or minus_zero_value objects instead of constant heap numbers with NaN or -0.0 values. BUG=chromium:625547 Committed: https://crrev.com/acd674db100339f1364358825763b2021c814ad9 Cr-Commit-Position: refs/heads/master@{#37495}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -29 lines)			Patch
	M	src/crankshaft/hydrogen-instructions.cc	View		2 chunks	+26 lines, -14 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-625547.js	View		1 chunk	+12 lines, -15 lines	0 comments	Download

Depends on Patchset:

Total messages: 12 (5 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115413002/1

4 years, 5 months ago (2016-07-04 09:31:48 UTC) #2

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 5 months ago (2016-07-04 09:53:19 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115413002/1

4 years, 5 months ago (2016-07-04 09:56:48 UTC) #9

commit-bot: I haz the power

4 years, 5 months ago (2016-07-04 09:59:33 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/acd674db100339f1364358825763b2021c814ad9
Cr-Commit-Position: refs/heads/master@{#37495}