Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2115213002: Disable SPDY/3.1. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable SPDY/3.1. * Remove SPDY field trial. * Add HTTP2 field trial to provide a kill switch for HTTP/2 just in case. * Remove enable_spdy31 flag. BUG=624095, 521597 Committed: https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245 Cr-Commit-Position: refs/heads/master@{#404443}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase on https://crrev.com/2111243004. #

Patch Set 3 : Rebase on https://crrev.com/2129973002. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -224 lines) Patch
M chrome/browser/io_thread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +1 line, -9 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 1 5 chunks +14 lines, -78 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 4 chunks +6 lines, -56 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/crnet/crnet_environment.mm View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 11 chunks +32 lines, -46 lines 0 comments Download
M net/log/net_log_util.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Bence
Nicolas: PTAL at jingle/glue/ mef: PTAL at ios/crnet/ bengr: PTAL at components/data_reduction_proxy/ Ryan: PTAL at ...
4 years, 5 months ago (2016-07-02 15:38:17 UTC) #2
Nicolas Zea
jingle lgtm
4 years, 5 months ago (2016-07-06 17:14:34 UTC) #3
mef
ios/crnet lgtm
4 years, 5 months ago (2016-07-06 17:15:43 UTC) #4
Ryan Hamilton
lgtm https://codereview.chromium.org/2115213002/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/2115213002/diff/1/net/http/http_network_transaction_unittest.cc#newcode137 net/http/http_network_transaction_unittest.cc:137: "Alt-Svc: npn-h2=\"mail.example.org:443\"\r\n"; Is "npn-h2" the right header?
4 years, 5 months ago (2016-07-06 19:24:58 UTC) #5
Bence
https://codereview.chromium.org/2115213002/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/2115213002/diff/1/net/http/http_network_transaction_unittest.cc#newcode137 net/http/http_network_transaction_unittest.cc:137: "Alt-Svc: npn-h2=\"mail.example.org:443\"\r\n"; On 2016/07/06 19:24:58, Ryan Hamilton wrote: > ...
4 years, 5 months ago (2016-07-07 16:20:41 UTC) #6
bengr
components/d_r_p/* lgtm
4 years, 5 months ago (2016-07-08 16:25:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115213002/40001
4 years, 5 months ago (2016-07-08 17:16:38 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 18:17:59 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 18:20:50 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2df4b5245b9c4350001c238dffe46d46fcf0c245
Cr-Commit-Position: refs/heads/master@{#404443}

Powered by Google App Engine
This is Rietveld 408576698