Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2115203002: [Reland] [Media Router] Allow users to update cloud services pref when sync is not active. (Closed)

Created:
4 years, 5 months ago by apacible
Modified:
4 years, 5 months ago
Reviewers:
msw, imcheng
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Reland] [Media Router] Allow users to update cloud services pref when sync is not active. There are two places users can update their cloud services pref: - First run flow, with a checkbox - Contextual menu, with a toggle Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices. In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services. [Reland Comments] This was initially reverted because it caused failures on official bots; there were #includes that were mistakenly removed. BUG=621255, 623330 TBR=msw, imcheng NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17 Cr-Commit-Position: refs/heads/master@{#402072} patch from issue 2078213002 at patchset 160001 (http://crrev.com/2078213002#ps160001) Review-Url: https://codereview.chromium.org/2093353002 Cr-Commit-Position: refs/heads/master@{#402596} (cherry picked from commit eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -20 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu.cc View 2 chunks +4 lines, -11 lines 0 comments Download
A chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115203002/1
4 years, 5 months ago (2016-07-02 02:39:06 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-02 02:39:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115203002/1
4 years, 5 months ago (2016-07-02 02:42:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 02:44:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698