Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: media/renderers/renderer_impl_unittest.cc

Issue 2115143002: Transition media element to HAVE_CURRENT_DATA upon underflow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/renderer_impl_unittest.cc
diff --git a/media/renderers/renderer_impl_unittest.cc b/media/renderers/renderer_impl_unittest.cc
index 28953d9f0f9ee40a04abc1d1f7af3ce99d65cf84..62d6f85595fb5251bcfebf44b1bbe124101182b5 100644
--- a/media/renderers/renderer_impl_unittest.cc
+++ b/media/renderers/renderer_impl_unittest.cc
@@ -469,6 +469,7 @@ TEST_F(RendererImplTest, FlushAfterUnderflow) {
// Simulate underflow.
EXPECT_CALL(time_source_, StopTicking());
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
audio_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
// Flush while underflowed. We shouldn't call StopTicking() again.
@@ -587,6 +588,7 @@ TEST_F(RendererImplTest, AudioUnderflow) {
// Underflow should occur immediately with a single audio track.
EXPECT_CALL(time_source_, StopTicking());
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
audio_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
}
@@ -597,6 +599,7 @@ TEST_F(RendererImplTest, AudioUnderflowWithVideo) {
// Underflow should be immediate when both audio and video are present and
// audio underflows.
EXPECT_CALL(time_source_, StopTicking());
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
audio_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
}
@@ -606,6 +609,7 @@ TEST_F(RendererImplTest, VideoUnderflow) {
// Underflow should occur immediately with a single video track.
EXPECT_CALL(time_source_, StopTicking());
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
video_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
}
@@ -619,6 +623,7 @@ TEST_F(RendererImplTest, VideoUnderflowWithAudio) {
// Underflow should be delayed when both audio and video are present and video
// underflows.
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
video_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
Mock::VerifyAndClearExpectations(&time_source_);
@@ -636,6 +641,8 @@ TEST_F(RendererImplTest, VideoUnderflowWithAudioVideoRecovers) {
// Underflow should be delayed when both audio and video are present and video
// underflows.
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING))
+ .Times(0);
video_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
Mock::VerifyAndClearExpectations(&time_source_);
@@ -654,9 +661,12 @@ TEST_F(RendererImplTest, VideoAndAudioUnderflow) {
// Underflow should be delayed when both audio and video are present and video
// underflows.
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING))
+ .Times(0);
video_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
Mock::VerifyAndClearExpectations(&time_source_);
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
EXPECT_CALL(time_source_, StopTicking());
audio_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
@@ -674,6 +684,7 @@ TEST_F(RendererImplTest, VideoUnderflowWithAudioFlush) {
// Simulate the cases where audio underflows and then video underflows.
EXPECT_CALL(time_source_, StopTicking());
+ EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
audio_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
video_renderer_client_->OnBufferingStateChange(BUFFERING_HAVE_NOTHING);
Mock::VerifyAndClearExpectations(&time_source_);
« no previous file with comments | « media/renderers/renderer_impl.cc ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-play-stall.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698