Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2115143002: Transition media element to HAVE_CURRENT_DATA upon underflow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | media/renderers/renderer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/blink/webmediaplayer_impl.h" 5 #include "media/blink/webmediaplayer_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state); 304 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
305 EXPECT_FALSE(state.is_memory_reporting_enabled); 305 EXPECT_FALSE(state.is_memory_reporting_enabled);
306 EXPECT_TRUE(state.is_suspended); 306 EXPECT_TRUE(state.is_suspended);
307 307
308 state = ComputeMustSuspendPlayState(); 308 state = ComputeMustSuspendPlayState();
309 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state); 309 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
310 EXPECT_FALSE(state.is_memory_reporting_enabled); 310 EXPECT_FALSE(state.is_memory_reporting_enabled);
311 EXPECT_TRUE(state.is_suspended); 311 EXPECT_TRUE(state.is_suspended);
312 } 312 }
313 313
314 TEST_F(WebMediaPlayerImplTest, ComputePlayState_PlayingThenUnderflow) {
315 WebMediaPlayerImpl::PlayState state;
316 SetMetadata(true, true);
317 SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
318 SetPaused(false);
319 SetReadyState(blink::WebMediaPlayer::ReadyStateHaveCurrentData);
320
321 // Underflow should not trigger idle suspend. The user is still playing the
322 // the video, just waiting on the network.
323 state = ComputePlayState();
324 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
325 EXPECT_TRUE(state.is_memory_reporting_enabled);
326 EXPECT_FALSE(state.is_suspended);
327
328 // Background suspend should still be possible during underflow.
329 state = ComputeBackgroundedPlayState();
330 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
331 EXPECT_FALSE(state.is_memory_reporting_enabled);
332 EXPECT_TRUE(state.is_suspended);
333
334 // Forced suspend should still be possible during underflow.
335 state = ComputeMustSuspendPlayState();
336 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
337 EXPECT_FALSE(state.is_memory_reporting_enabled);
338 EXPECT_TRUE(state.is_suspended);
339 }
340
314 TEST_F(WebMediaPlayerImplTest, ComputePlayState_Playing_AudioOnly) { 341 TEST_F(WebMediaPlayerImplTest, ComputePlayState_Playing_AudioOnly) {
315 WebMediaPlayerImpl::PlayState state; 342 WebMediaPlayerImpl::PlayState state;
316 SetMetadata(true, false); 343 SetMetadata(true, false);
317 SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData); 344 SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
318 SetPaused(false); 345 SetPaused(false);
319 346
320 state = ComputePlayState(); 347 state = ComputePlayState();
321 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state); 348 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
322 EXPECT_TRUE(state.is_memory_reporting_enabled); 349 EXPECT_TRUE(state.is_memory_reporting_enabled);
323 EXPECT_FALSE(state.is_suspended); 350 EXPECT_FALSE(state.is_suspended);
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 EXPECT_FALSE(state.is_suspended); 459 EXPECT_FALSE(state.is_suspended);
433 460
434 SetPaused(false); 461 SetPaused(false);
435 state = ComputePlayStateSuspended(); 462 state = ComputePlayStateSuspended();
436 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state); 463 EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
437 EXPECT_TRUE(state.is_memory_reporting_enabled); 464 EXPECT_TRUE(state.is_memory_reporting_enabled);
438 EXPECT_FALSE(state.is_suspended); 465 EXPECT_FALSE(state.is_suspended);
439 } 466 }
440 467
441 } // namespace media 468 } // namespace media
OLDNEW
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | media/renderers/renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698