Source/platform/graphics/filters/FEGaussianBlur.h - Issue 211513003: Returning IntSize to store calculated kernel size values

Side by Side Diff: Source/platform/graphics/filters/FEGaussianBlur.h

Issue 211513003: Returning IntSize to store calculated kernel size values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/platform/graphics/filters/FEDropShadow.cpp ('K') | « Source/platform/graphics/filters/FEDropShadow.cpp ('k') | Source/platform/graphics/filters/FEGaussianBlur.cpp » ('j') | Source/platform/graphics/filters/FEGaussianBlur.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>

4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>	4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>

5 * Copyright (C) 2013 Google Inc. All rights reserved.	5 * Copyright (C) 2013 Google Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 22 matching lines...) Expand all Loading...
33 static PassRefPtr<FEGaussianBlur> create(Filter*, float, float);	33 static PassRefPtr<FEGaussianBlur> create(Filter*, float, float);

34	34

35 float stdDeviationX() const;	35 float stdDeviationX() const;

36 void setStdDeviationX(float);	36 void setStdDeviationX(float);

37	37

38 float stdDeviationY() const;	38 float stdDeviationY() const;

39 void setStdDeviationY(float);	39 void setStdDeviationY(float);

40	40

41 virtual FloatRect mapRect(const FloatRect&, bool forward = true) OVERRIDE FI NAL;	41 virtual FloatRect mapRect(const FloatRect&, bool forward = true) OVERRIDE FI NAL;

42 virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedRect) OVERRIDE;	42 virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedRect) OVERRIDE;

43 static void calculateKernelSize(Filter*, unsigned& kernelSizeX, unsigned& ke rnelSizeY, float stdX, float stdY);	43 static IntSize calculateKernelSize(Filter*, float stdX, float stdY);
	Stephen White 2014/03/26 00:22:21 Nit: it seems inconsistent for calculateUnscaledKe Nit: it seems inconsistent for calculateUnscaledKernelSize to take a FloatPoint, but not calculateKernelSize.
44 static void calculateUnscaledKernelSize(unsigned& kernelSizeX, unsigned& ker nelSizeY, float stdX, float stdY);	44 static IntSize calculateUnscaledKernelSize(FloatPoint std);
	pdr. 2014/03/26 00:00:13 Can these functions take const references instead? Can these functions take const references instead? static IntSize calculateKernelSize(const Filter&, float stdX, float stdY); static IntSize calculateUnscaledKernelSize(const FloatPoint&); Savago 2014/03/26 00:12:24 Indeed, they can. I will update the patch. Indeed, they can. I will update the patch. Stephen White 2014/03/26 00:22:21 This should probably be const FloatPoint&. This should probably be const FloatPoint&.
45	45

46 virtual TextStream& externalRepresentation(TextStream&, int indention) const OVERRIDE;	46 virtual TextStream& externalRepresentation(TextStream&, int indention) const OVERRIDE;

47	47

48 private:	48 private:

49 static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs	49 static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs

50	50

51 template<typename Type>	51 template<typename Type>

52 friend class ParallelJobs;	52 friend class ParallelJobs;

53	53

54 struct PlatformApplyParameters {	54 struct PlatformApplyParameters {

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
102 dRight++;	102 dRight++;

103 std++;	103 std++;

104 }	104 }

105 break;	105 break;

106 }	106 }

107 }	107 }

108	108

109 } // namespace WebCore	109 } // namespace WebCore

110	110

111 #endif // FEGaussianBlur_h	111 #endif // FEGaussianBlur_h

OLD	NEW