Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2115033002: Adds QUIC_VERSION_36 which adds support to force HOL blocking between streams for measurement purpo… (Closed)

Created:
4 years, 5 months ago by Buck
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@126085461
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds QUIC_VERSION_36 which adds support to force HOL blocking between streams for measurement purposes. Protected by --quic_enable_version_36. Force HOL blocking between streams by tunneling all stream data through the headers stream encapsulated in HTTP/2.0 data frames. The experiment will be triggered via Finch setting a new QUIC config parameter |force_hol_blocking| (tag FHOL). This will be the basis for comparison between QUIC and QUIC+FHOL to separate HOL performance impacts from all the other QUIC benefits (zero rtt, better loss recovery, etc.). Merge internal change: 126418608 R=rch@chromium.org BUG= Committed: https://crrev.com/3f0ed361341fb90fa0bd7964ed36d28cf245591b Cr-Commit-Position: refs/heads/master@{#404245}

Patch Set 1 #

Patch Set 2 : rebase-update #

Patch Set 3 : possible bugfix for trybot failure. #

Patch Set 4 : use scoped_refptr instead of manual referencing #

Patch Set 5 : still working on asan errors #

Patch Set 6 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+560 lines, -83 lines) Patch
M net/quic/crypto/crypto_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_config.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 2 chunks +14 lines, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.h View 2 chunks +15 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 2 3 4 5 5 chunks +138 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 2 3 9 chunks +127 lines, -5 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 4 chunks +24 lines, -1 line 0 comments Download
M net/quic/quic_spdy_session.h View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 2 chunks +27 lines, -1 line 0 comments Download
M net/quic/quic_spdy_stream.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 8 chunks +77 lines, -60 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 6 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Buck
4 years, 5 months ago (2016-07-01 20:39:48 UTC) #1
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-07-01 21:28:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115033002/1
4 years, 5 months ago (2016-07-01 22:58:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/185385)
4 years, 5 months ago (2016-07-01 23:16:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115033002/20001
4 years, 5 months ago (2016-07-01 23:19:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/185397)
4 years, 5 months ago (2016-07-01 23:51:11 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115033002/40001
4 years, 5 months ago (2016-07-02 00:16:30 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/185441)
4 years, 5 months ago (2016-07-02 00:56:25 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115033002/100001
4 years, 5 months ago (2016-07-07 18:43:18 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 20:46:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115033002/100001
4 years, 5 months ago (2016-07-07 20:48:02 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-07 22:10:59 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 22:11:42 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 22:13:23 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3f0ed361341fb90fa0bd7964ed36d28cf245591b
Cr-Commit-Position: refs/heads/master@{#404245}

Powered by Google App Engine
This is Rietveld 408576698