Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 void collectLayerFragments(PaintLayerFragments&, const LayoutRect& layerBoun dingBox, const LayoutRect& dirtyRect); 164 void collectLayerFragments(PaintLayerFragments&, const LayoutRect& layerBoun dingBox, const LayoutRect& dirtyRect);
165 165
166 LayoutUnit columnGap() const; 166 LayoutUnit columnGap() const;
167 167
168 // The "CSS actual" value of column-count. This includes overflowing columns , if any. 168 // The "CSS actual" value of column-count. This includes overflowing columns , if any.
169 unsigned actualColumnCount() const; 169 unsigned actualColumnCount() const;
170 170
171 const char* name() const override { return "LayoutMultiColumnSet"; } 171 const char* name() const override { return "LayoutMultiColumnSet"; }
172 172
173 // Sets |columnRuleBounds| to the bounds of each column rule rect's painted extent, adjusted by paint offset,
174 // before pixel snapping. Returns true if column rules should be painted at all.
175 bool computeColumnRuleBounds(const LayoutPoint& paintOffset, Vector<LayoutRe ct>& columnRuleBounds) const;
176
177 LayoutRect localOverflowRectForPaintInvalidation() const override;
178
173 protected: 179 protected:
174 LayoutMultiColumnSet(LayoutFlowThread*); 180 LayoutMultiColumnSet(LayoutFlowThread*);
175 181
176 private: 182 private:
177 unsigned fragmentainerGroupIndexAtFlowThreadOffset(LayoutUnit) const; 183 unsigned fragmentainerGroupIndexAtFlowThreadOffset(LayoutUnit) const;
178 184
179 void insertedIntoTree() final; 185 void insertedIntoTree() final;
180 void willBeRemovedFromTree() final; 186 void willBeRemovedFromTree() final;
181 187
182 bool isSelfCollapsingBlock() const override { return false; } 188 bool isSelfCollapsingBlock() const override { return false; }
(...skipping 21 matching lines...) Expand all
204 210
205 bool m_initialHeightCalculated; 211 bool m_initialHeightCalculated;
206 }; 212 };
207 213
208 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet()); 214 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet());
209 215
210 } // namespace blink 216 } // namespace blink
211 217
212 #endif // LayoutMultiColumnSet_h 218 #endif // LayoutMultiColumnSet_h
213 219
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698