chrome/browser/first_run/first_run.cc - Issue 21150006: Introduce --cancel-first-run and reduce the strength of --no-first-run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run.cc

Issue 21150006: Introduce --cancel-first-run and reduce the strength of --no-first-run. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace hardcoded --no-first-run in scripts Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main_mac.mm ('K') | « chrome/browser/extensions/api/record/record_api.cc ('k') | chrome/browser/process_singleton_browsertest.cc » ('j') | chrome_frame/chrome_frame_automation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/first_run.cc

diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc

index 29c443b63fb46941dffdd0a09c6253f6323c0104..923bfe75f2c85668dde1e57cb0c027d690cd1535 100644

--- a/chrome/browser/first_run/first_run.cc

+++ b/chrome/browser/first_run/first_run.cc

@@ -482,9 +482,10 @@ bool IsChromeFirstRun() {

const CommandLine* command_line = CommandLine::ForCurrentProcess();

if (command_line->HasSwitch(switches::kForceFirstRun)) {

internal::first_run_ = internal::FIRST_RUN_TRUE;

- } else if (command_line->HasSwitch(switches::kNoFirstRun)) {

+ } else if (command_line->HasSwitch(switches::kCancelFirstRun)) {

internal::first_run_ = internal::FIRST_RUN_CANCEL;

grt (UTC plus 2) 2013/07/30 02:48:16 FIRST_RUN_CANCEL doesn't seem to exist in the repo

gab 2013/07/30 12:58:54 Ah, yes, can't sneak anything by you ;)! Based on

- } else if (internal::GetFirstRunSentinelFilePath(&first_run_sentinel) &&

+ } else if (!command_line->HasSwitch(switches::kSkipFirstRun) &&

+ internal::GetFirstRunSentinelFilePath(&first_run_sentinel) &&

!base::PathExists(first_run_sentinel)) {

internal::first_run_ = internal::FIRST_RUN_TRUE;

}