chrome_frame/chrome_launcher_unittest.cc - Issue 21150006: Introduce --cancel-first-run and reduce the strength of --no-first-run.

Side by Side Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 21150006: Introduce --cancel-first-run and reduce the strength of --no-first-run. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add first_run::IsFirstRunSuppressed() Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/chrome_switches.cc ('K') | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/files/file_path.h"	6 #include "base/files/file_path.h"

7 #include "chrome/common/chrome_switches.h"	7 #include "chrome/common/chrome_switches.h"

8 #include "chrome_frame/chrome_launcher.h"	8 #include "chrome_frame/chrome_launcher.h"

9 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

10	10

11 TEST(ChromeLauncher, IsValidCommandLine) {	11 TEST(ChromeLauncher, IsValidCommandLine) {

12 CommandLine bad(base::FilePath(L"dummy.exe"));	12 CommandLine bad(base::FilePath(L"dummy.exe"));

13 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist	13 bad.AppendSwitch(switches::kSkipFirstRun); // in whitelist

14 bad.AppendSwitch("no-such-switch"); // does not exist	14 bad.AppendSwitch("no-such-switch"); // does not exist

15 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist	15 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist

16	16

17 EXPECT_FALSE(chrome_launcher::IsValidCommandLine(	17 EXPECT_FALSE(chrome_launcher::IsValidCommandLine(

18 bad.GetCommandLineString().c_str()));	18 bad.GetCommandLineString().c_str()));

19	19

20 CommandLine good(base::FilePath(L"dummy.exe"));	20 CommandLine good(base::FilePath(L"dummy.exe"));

21 good.AppendSwitch(switches::kNoFirstRun); // in whitelist	21 good.AppendSwitch(switches::kSkipFirstRun); // in whitelist

22 good.AppendSwitch(switches::kDisableBackgroundMode); // in whitelist	22 good.AppendSwitch(switches::kDisableBackgroundMode); // in whitelist

23 good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist	23 good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist

24	24

25 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(	25 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

26 good.GetCommandLineString().c_str()));	26 good.GetCommandLineString().c_str()));

27	27

28 CommandLine no_params(base::FilePath(L"dummy.exe"));	28 CommandLine no_params(base::FilePath(L"dummy.exe"));

29 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(	29 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

30 no_params.GetCommandLineString().c_str()));	30 no_params.GetCommandLineString().c_str()));

31	31

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));	66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));

67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));	67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));

68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));	68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));

69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));	69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));

70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));	70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));

71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));	71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));

72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));	72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));

73 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));	73 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));

74 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));	74 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));

75 }	75 }

OLD	NEW