Introduce --cancel-first-run and reduce the strength of --no-first-run.

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 122 matching lines @@
 
 // The value of this switch tells the app to listen for and broadcast
 // automation-related messages on IPC channel with the given ID.
 const char kAutomationClientChannelID[]     = "automation-channel";
 
 // Causes the automation provider to reinitialize its IPC channel instead of
 // shutting down when a client disconnects.
 const char kAutomationReinitializeOnChannelError[] =
     "automation-reinitialize-on-channel-error";
 
+// Similar to kSkipFirstRun, but also drops the First Run beacon so that first
+// run will not occur in subsequent runs either.
+const char kCancelFirstRun[]                = "cancel-first-run";
+
 // How often (in seconds) to check for updates. Should only be used for testing
 // purposes.
 const char kCheckForUpdateIntervalSec[]     = "check-for-update-interval";
 
 // Checks the cloud print connector policy, informing the service process if
 // the policy is set to disallow the connector, then quits.
 const char kCheckCloudPrintConnectorPolicy[] =
     "check-cloud-print-connector-policy";
 
 // Run Chrome in Chrome Frame mode. This means that Chrome expects to be run
@@ skipping 629 matching lines @@
 // The file descriptor limit is set to the value of this switch, subject to the
 // OS hard limits. Useful for testing that file descriptor exhaustion is
 // handled gracefully.
 const char kFileDescriptorLimit[]           = "file-descriptor-limit";
 
 // Forces application mode. This hides certain system UI elements and forces
 // the app to be installed if it hasn't been already.
 const char kForceAppMode[]                  = "force-app-mode";
 
 // Displays the First Run experience when the browser is started, regardless of
-// whether or not it's actually the First Run (this overrides kNoFirstRun).
+// whether or not it's actually the First Run (this overrides kSkipFirstRun and
+// kCancelFirstRun).
 const char kForceFirstRun[]                 = "force-first-run";
 
 // Tries to load cloud policy for every signed in user, regardless of whether
 // they are a dasher user or not. Used to allow any GAIA account to be used for
 // testing the cloud policy framework.
 const char kForceLoadCloudPolicy[]          = "force-load-cloud-policy";
 
 // Enables using GAIA information to populate profile name and icon.
 const char kGaiaProfileInfo[]               = "gaia-profile-info";
 
@@ skipping 151 matching lines @@
 
 // Don't record/playback events when using record & playback.
 const char kNoEvents[]                      = "no-events";
 
 // Disables all experiments set on about:flags. Does not disable about:flags
 // itself. Useful if an experiment makes chrome crash at startup: One can start
 // chrome with --no-experiments, disable the problematic lab at about:flags and
 // then restart chrome without this switch again.
 const char kNoExperiments[]                 = "no-experiments";
 
-// Skip First Run tasks, whether or not it's actually the First Run. Overridden
-// by kForceFirstRun.
-// Also drops the First Run beacon so that First Run will not occur in
-// subsequent runs as well.
-const char kNoFirstRun[]                    = "no-first-run";

[cpu_(ooo_6.6-7.5), 2013/07/30 21:41:36]

please check/search if documentation in chromium.org mentions this flag, I
recall a page explaining master prefs.

[gab, 2013/07/31 00:00:51]

Actually this makes me realize that a bunch of random stuff using chrome might
use this flag (e.g., http://www.chromium.org/developers/testing/fuzzers suggests
using this and in might be hardcoded in some scripts outside of our src/).

The idea behind changing the name was to confirm/prove that I didn't forget an
instance of kNoFirstRun somewhere without deciding which flag it should actually
use.

How about renaming --skip-first-run back to --no-first-run after I get a green
try run with --skip-first-run (to first confirm I didn't forget any...)?
Although I did git grep for kNoFirstRun and --no-first-run to make sure there
were none left...

[gab, 2013/08/01 15:14:49]

ping, what do you guys think of ^^ ?

-
 // Support a separate switch that enables the v8 playback extension.
 // The extension causes javascript calls to Date.now() and Math.random()
 // to return consistent values, such that subsequent loads of the same
 // page will result in consistent js-generated data and XHR requests.
 // Pages may still be able to generate inconsistent data from plugins.
 const char kNoJsRandomness[]                = "no-js-randomness";
 
 // Disables the timeout during registration of a new managed-user profile;
 // useful for debugging.
 const char kNoManagedUserRegistrationTimeout[]  =
@@ skipping 274 matching lines @@
 
 // Simulates an update being available.
 const char kSimulateUpgrade[]               = "simulate-upgrade";
 
 // Simulates a critical update being available.
 const char kSimulateCriticalUpdate[]        = "simulate-critical-update";
 
 // Simulates that current version is outdated.
 const char kSimulateOutdated[]               = "simulate-outdated";
 
+// Skip First Run tasks, whether or not it's actually the First Run. Overridden
+// by kForceFirstRun. This doesn't prevent first run from occuring the next time
+// chrome is launched without this flag.
+const char kSkipFirstRun[]                    = "skip-first-run";
+
 // Replaces the buffered data source for <audio> and <video> with a simplified
 // resource loader that downloads the entire resource into memory.
 
 // Origin for which SpdyProxy authentication is supported.
 const char kSpdyProxyAuthOrigin[]           = "spdy-proxy-auth-origin";
 
 // Speculative resource prefetching.
 const char kSpeculativeResourcePrefetching[] =
     "speculative-resource-prefetching";
 
@@ skipping 304 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches