Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2114963002: Create Java infrastructure for UI Render Tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 2ece634b09b1e037a72a4b0bdb8b07086a5d5189..9ac48855d8b3979dddeed45bd3d0285f07acd296 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -8,6 +8,7 @@ import android.graphics.Bitmap;
import org.chromium.base.Callback;
import org.chromium.base.annotations.CalledByNative;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsSource.SnippetsObserver;
import org.chromium.chrome.browser.profiles.Profile;
import java.util.ArrayList;
@@ -16,23 +17,13 @@ import java.util.List;
/**
* Provides access to the snippets to display on the NTP using the C++ NTP Snippets Service
*/
-public class SnippetsBridge {
+public class SnippetsBridge implements SnippetsSource {
private static final String TAG = "SnippetsBridge";
private long mNativeSnippetsBridge;
private SnippetsObserver mObserver;
/**
- * An observer for events in the snippets service.
- */
- public interface SnippetsObserver {
- void onSnippetsReceived(List<SnippetArticle> snippets);
-
- /** Called when the service is about to change its state. */
- void onDisabledReasonChanged(int disabledReason);
- }
-
- /**
* Creates a SnippetsBridge for getting snippet data for the current user.
*
* @param profile Profile of the user that we will retrieve snippets for.
@@ -73,6 +64,7 @@ public class SnippetsBridge {
*
* @param snippet Snippet to discard.
*/
+ @Override
public void discardSnippet(SnippetArticle snippet) {
assert mNativeSnippetsBridge != 0;
nativeDiscardSnippet(mNativeSnippetsBridge, snippet.mId);
@@ -81,6 +73,7 @@ public class SnippetsBridge {
/**
* Fetches the thumbnail image for a snippet.
*/
+ @Override
public void fetchSnippetImage(SnippetArticle snippet, Callback<Bitmap> callback) {
nativeFetchImage(mNativeSnippetsBridge, snippet.mId, callback);
}
@@ -88,6 +81,7 @@ public class SnippetsBridge {
/**
* Checks whether a snippet has been visited by querying the history for the snippet's URL.
*/
+ @Override
public void getSnippedVisited(SnippetArticle snippet, Callback<Boolean> callback) {
assert mNativeSnippetsBridge != 0;
nativeSnippetVisited(mNativeSnippetsBridge, callback, snippet.mUrl);
@@ -102,6 +96,7 @@ public class SnippetsBridge {
* @param observer object to notify when snippets are received, or {@code null} if we want to
* stop observing.
*/
+ @Override
public void setObserver(SnippetsObserver observer) {
assert mObserver == null || mObserver == observer;
@@ -109,6 +104,7 @@ public class SnippetsBridge {
nativeSetObserver(mNativeSnippetsBridge, observer == null ? null : this);
}
+ @Override
public int getDisabledReason() {
assert mNativeSnippetsBridge != 0;
return nativeGetDisabledReason(mNativeSnippetsBridge);

Powered by Google App Engine
This is Rietveld 408576698