Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 211493005: Revert 259371 "clang roll 198389:202554 reloaded" (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 259371 "clang roll 198389:202554 reloaded" Even though the libc++ dependency is gone, clang still depends on /usr/lib/libedit.3.dylib suddently, which doesn't exist on 10.6. Backing out while I investigate... > clang roll 198389:202554 reloaded > > The first try is at https://codereview.chromium.org/195623002/ . Patch set 1 > is identical to that CL, patch set 2 has what changed. > > The big change is that clang/mac is built in gnu++98 mode and doesn't link > to libc++, to buy us time until the next roll for upgrading our bots to 10.7. > This includes blink plugin changes up to r256229 (inclusive). > > BUG=351479, 287029, 341352, 333968, 335325 > R=hans@chromium.org > TBR=hans@chromium.org > > Review URL: https://codereview.chromium.org/211213004 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -713 lines) Patch
M trunk/src/build/common.gypi View 4 chunks +1 line, -7 lines 0 comments Download
M trunk/src/build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/third_party/libxml/libxml.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/tools/clang/blink_gc_plugin/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/clang/plugins/ChromeClassTester.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/tools/clang/scripts/package.sh View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/tools/clang/scripts/plugin_flags.sh View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/tools/clang/scripts/update.sh View 5 chunks +11 lines, -695 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 9 months ago (2014-03-25 22:56:14 UTC) #1
Nico
6 years, 9 months ago (2014-03-25 22:56:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r259378 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698