Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2114923002: Don't sync session.startup_urls and session.urls_to_restore_on_startup to mobile platforms. (Closed)

Created:
4 years, 5 months ago by melandory
Modified:
4 years, 5 months ago
Reviewers:
battre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't sync session.startup_urls to mobile platforms. Chrome will start sync prefs to mobile. It's not desired behaviour for the session.startup_urls and the session.urls_to_restore_on_startup prefs. BUG=622620 Committed: https://crrev.com/a54a050049d669a1c55517159d2c5b0fa95e7e4b Cr-Commit-Position: refs/heads/master@{#403436}

Patch Set 1 #

Patch Set 2 : Don't sync session.startup_urls and session.urls_to_restore_on_startup to mobile platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/prefs/session_startup_pref.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
melandory
Hi Dominic, please take a look.
4 years, 5 months ago (2016-07-01 10:53:45 UTC) #3
battre
lgtm
4 years, 5 months ago (2016-07-01 11:15:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114923002/20001
4 years, 5 months ago (2016-07-01 11:17:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 11:32:19 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 11:34:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a54a050049d669a1c55517159d2c5b0fa95e7e4b
Cr-Commit-Position: refs/heads/master@{#403436}

Powered by Google App Engine
This is Rietveld 408576698