Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 21149008: refactoring for SK_FONTHOST_USES_FONTMGR option (Closed)

Created:
7 years, 4 months ago by reed1
Modified:
7 years, 4 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

refactoring for SK_FONTHOST_USES_FONTMGR option BUG= R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=10440

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -120 lines) Patch
M include/core/SkFontHost.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkTypeface.h View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M include/ports/SkFontMgr.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkFontHost.cpp View 1 2 3 3 chunks +51 lines, -1 line 0 comments Download
M src/core/SkTypeface.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 3 4 19 chunks +66 lines, -53 lines 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 2 3 13 chunks +80 lines, -66 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
As part of the effort to run two fonthosts/fontmgrs at once, I need to eliminate ...
7 years, 4 months ago (2013-07-30 15:41:05 UTC) #1
bungeman-skia
lgtm
7 years, 4 months ago (2013-07-30 15:55:24 UTC) #2
reed1
7 years, 4 months ago (2013-07-30 17:47:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r10440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698