Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2114883002: Cherry pick CoreText Helvetica collision fix into HarfBuzz (Closed)

Created:
4 years, 5 months ago by drott
Modified:
4 years, 5 months ago
Reviewers:
behdad, kojii, eae, bashi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cherry pick CoreText Helvetica collision fix into HarfBuzz Cherry picking HarfBuzz commit 46809dee30232d4 into HarfBuzz in order to address the incompatibility with third-party font management software and Type 1 versions of Helvetica. BUG=132252 R=kojii,eae,behdad Committed: https://crrev.com/deec23f32462827a76e3524d04fa6b13784a6ec8 Cr-Commit-Position: refs/heads/master@{#403427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
drott
4 years, 5 months ago (2016-07-01 07:17:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114883002/1
4 years, 5 months ago (2016-07-01 07:17:56 UTC) #3
bashi
lgtm as a tentative fix.
4 years, 5 months ago (2016-07-01 07:27:01 UTC) #5
drott
On 2016/07/01 at 07:27:01, bashi wrote: > lgtm as a tentative fix. Thank you for ...
4 years, 5 months ago (2016-07-01 07:29:19 UTC) #6
bashi
On 2016/07/01 07:27:01, bashi1 wrote: > tentative ^^^ this is for cherry-picking itself.
4 years, 5 months ago (2016-07-01 07:29:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114883002/1
4 years, 5 months ago (2016-07-01 07:29:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 08:36:36 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 08:38:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deec23f32462827a76e3524d04fa6b13784a6ec8
Cr-Commit-Position: refs/heads/master@{#403427}

Powered by Google App Engine
This is Rietveld 408576698