Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2114873002: Clean up more naming in ComputedStyle (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
dstockwell
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up more naming in ComputedStyle Split this into two patches because the first one was getting too big. First patch: crrev.com/2115803002 Some more small naming fixes in ComputedStyle. - Renamed 'inherited' to 'm_styleInheritedData' - Renamed 'inherited_data' and 'noninherited_data' to 'm_inheritedData' and 'm_nonInheritedData' - Some other small fields changed to start with m BUG=622138 Committed: https://crrev.com/c65d0c0a618449f58c3824992f14c458cd2b5830 Cr-Commit-Position: refs/heads/master@{#403858}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Presubmit checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1000 lines, -996 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 32 chunks +704 lines, -700 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 40 chunks +296 lines, -296 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
sashab
Follow-up from other patch. :)
4 years, 5 months ago (2016-07-06 03:52:45 UTC) #2
dstockwell
lgtm
4 years, 5 months ago (2016-07-06 04:02:29 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2115803002 Patch 40001). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-06 04:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114873002/40001
4 years, 5 months ago (2016-07-06 04:31:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/212640)
4 years, 5 months ago (2016-07-06 04:37:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114873002/60001
4 years, 5 months ago (2016-07-06 05:04:59 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 06:52:11 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 06:53:36 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c65d0c0a618449f58c3824992f14c458cd2b5830
Cr-Commit-Position: refs/heads/master@{#403858}

Powered by Google App Engine
This is Rietveld 408576698