Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2114853002: [x87] Enable test cases which failed at know issue that x87 change sNaN to qNaN by default. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x87] Enable test cases which failed at know issue that x87 change sNaN to qNaN by default. Since the workaround (CL 36697 : 22a73e0d854638ca26d8a49434a605f1fde0daf8) for sNaN issue works, enable those test cases. BUG= Committed: https://crrev.com/5a2f5c128f860eb9aeed6cd37359fadb97946fd3 Cr-Commit-Position: refs/heads/master@{#37472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-01 02:52:56 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-01 03:30:28 UTC) #3
titzer
lgtm
4 years, 5 months ago (2016-07-01 07:08:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114853002/1
4 years, 5 months ago (2016-07-01 07:10:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 07:35:22 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 07:36:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a2f5c128f860eb9aeed6cd37359fadb97946fd3
Cr-Commit-Position: refs/heads/master@{#37472}

Powered by Google App Engine
This is Rietveld 408576698