source/row_common.cc - Issue 2114843002: API for deinterlacing YUV420 output on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: source/row_common.cc

Issue 2114843002: API for deinterlacing YUV420 output on Android (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master

Patch Set: initial unittest for Android420 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: source/row_common.cc

diff --git a/source/row_common.cc b/source/row_common.cc

index 32d2f686f20ade444f9ee62d3b2483e946bd92e2..61ade6ef369ced52b454fc38444c7c867d1e1dc9 100644

--- a/source/row_common.cc

+++ b/source/row_common.cc

@@ -988,7 +988,7 @@ void J400ToARGBRow_C(const uint8* src_y, uint8* dst_argb, int width) {

#define BG (UG * 128 + VG * 128 + YGB)

#define BR (VR * 128 + YGB)

-#if defined(__aarch64__)

+#if defined(__aarch64__) // 64 bit arm

const YuvConstants SIMD_ALIGNED(kYuvI601Constants) = {

{ -UB, -VR, -UB, -VR, -UB, -VR, -UB, -VR },

@@ -1005,7 +1005,7 @@ const YuvConstants SIMD_ALIGNED(kYvuI601Constants) = {

{ BR, BG, BB, 0, 0, 0, 0, 0 },

{ 0x0101 * YG, 0, 0, 0 }

};

-#elif defined(__arm__)

+#elif defined(__arm__) // 32 bit arm

const YuvConstants SIMD_ALIGNED(kYuvI601Constants) = {

{ -UB, -UB, -UB, -UB, -VR, -VR, -VR, -VR, 0, 0, 0, 0, 0, 0, 0, 0 },

{ UG, UG, UG, UG, VG, VG, VG, VG, 0, 0, 0, 0, 0, 0, 0, 0 },