Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2114843002: API for deinterlacing YUV420 output on Android (Closed)

Created:
4 years, 5 months ago by fbarchard1
Modified:
4 years, 5 months ago
Reviewers:
braveyao
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add libyuv:Android420ToI420 function which takes 3 pointers to Y,U,V and a pixel stride for U and V. The pixel stride is expected to be 1 or 2. TEST=LibYUVConvertTest.Android420ToI420_Opt BUG=libyuv:604 R=braveyao@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/84e04699c2da42e8868a13944a242ac54656ffa3

Patch Set 1 #

Patch Set 2 : prototype header #

Patch Set 3 : split pixels #

Patch Set 4 : initial unittest for Android420 #

Total comments: 6

Patch Set 5 : fixed white spacing #

Patch Set 6 : lint fixes for spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -5 lines) Patch
M include/libyuv/convert.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M source/convert.cc View 1 2 3 4 2 chunks +144 lines, -0 lines 0 comments Download
M source/row_common.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M unit_test/convert_test.cc View 1 2 3 1 chunk +142 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
Initial Android420 support
4 years, 5 months ago (2016-07-12 18:24:47 UTC) #2
braveyao
lgtm with nits. https://codereview.chromium.org/2114843002/diff/60001/source/convert.cc File source/convert.cc (right): https://codereview.chromium.org/2114843002/diff/60001/source/convert.cc#newcode230 source/convert.cc:230: // width and height are plane ...
4 years, 5 months ago (2016-07-12 21:42:05 UTC) #4
fbarchard1
x86 C I420ToI420_Opt (174 ms) I422ToI420_Opt (164 ms) Android420ToI420_Opt (319 ms) NV12ToI420_Opt (360 ms) NV21ToI420_Opt ...
4 years, 5 months ago (2016-07-12 23:19:38 UTC) #5
fbarchard1
4 years, 5 months ago (2016-07-12 23:23:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
84e04699c2da42e8868a13944a242ac54656ffa3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698