Convert quick_unlock/pin_keyboard to v2 Closure GYP

Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true

Committed: https://crrev.com/233cb242cfc75eab337ab317c48cd63f722fe796
Cr-Commit-Position: refs/heads/master@{#403503}

[Dan Beam, 2016-07-01 18:34:14]

Description was changed from

==========
Shuffle around the quick_unlock closure files

R=sammiequon@chromium.org
BUG=none
==========

to

==========
Shuffle around the quick_unlock closure files

R=sammiequon@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-01 19:19:28]

Description was changed from

==========
Shuffle around the quick_unlock closure files

R=sammiequon@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-01 19:20:13]

https://codereview.chromium.org/2114803004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/compiled_resources.gyp
(right):

https://codereview.chromium.org/2114803004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/compiled_resources.gyp:7:
'target_name': 'pin_keyboard',
you'll add:

'variables': {
  'depends': [
    '../../../../../ui/webui/resources/js/i18n_behavior.js',
  ],
},

in your patch

https://codereview.chromium.org/2114803004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2114803004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/compiled_resources2.gyp:9:
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:i18n_behavior',
I pre-added this because https://codereview.chromium.org/2108813002/ adds that
dependency (and it was simpler than trying to explain it)

[Dan Beam, 2016-07-01 19:26:17]

Description was changed from

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

[Dan Beam, 2016-07-01 19:26:28]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org
- sammiequon@chromium.org

[Dan Beam, 2016-07-01 19:26:35]

whoops, meant tommycli@

[tommycli, 2016-07-01 19:32:55]

lgtm

[Dan Beam, 2016-07-01 19:33:02]

https://codereview.chromium.org/2114803004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/compiled_resources.gyp
(right):

https://codereview.chromium.org/2114803004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/compiled_resources.gyp:7:
'target_name': 'pin_keyboard',
On 2016/07/01 19:20:13, Dan Beam wrote:
> you'll add:
> 
> 'variables': {
>   'depends': [
>     '../../../../../ui/webui/resources/js/i18n_behavior.js',
>   ],
> },
> 
> in your patch

whoops, ignore this

[Dan Beam, 2016-07-01 19:37:00]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-01 19:37:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 19:42:06]

Description was changed from

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

to

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

[commit-bot: I haz the power, 2016-07-01 19:42:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 19:42:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 19:44:03]

Description was changed from

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

to

==========
Convert quick_unlock/pin_keyboard to v2 Closure GYP

Unblocks https://codereview.chromium.org/2108813002/

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true

Committed: https://crrev.com/233cb242cfc75eab337ab317c48cd63f722fe796
Cr-Commit-Position: refs/heads/master@{#403503}
==========

[commit-bot: I haz the power, 2016-07-01 19:44:04]

Patchset 2 (id:??) landed as
https://crrev.com/233cb242cfc75eab337ab317c48cd63f722fe796
Cr-Commit-Position: refs/heads/master@{#403503}