Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 21148002: Implement AtkComponent and AtkValue interfaces. (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Implement AtkComponent and AtkValue interfaces. BUG=24585 R=aboxhall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214752

Patch Set 1 #

Total comments: 12

Patch Set 2 : Respond to feedback #

Patch Set 3 : Fix clang compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -70 lines) Patch
M content/browser/accessibility/browser_accessibility_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_gtk.cc View 1 2 8 chunks +204 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
7 years, 4 months ago (2013-07-29 20:34:14 UTC) #1
aboxhall
https://codereview.chromium.org/21148002/diff/1/content/browser/accessibility/browser_accessibility_gtk.cc File content/browser/accessibility/browser_accessibility_gtk.cc (right): https://codereview.chromium.org/21148002/diff/1/content/browser/accessibility/browser_accessibility_gtk.cc#newcode41 content/browser/accessibility/browser_accessibility_gtk.cc:41: return 0; Why return 0 instead of NULL here? ...
7 years, 4 months ago (2013-07-29 22:23:09 UTC) #2
dmazzoni
https://codereview.chromium.org/21148002/diff/1/content/browser/accessibility/browser_accessibility_gtk.cc File content/browser/accessibility/browser_accessibility_gtk.cc (right): https://codereview.chromium.org/21148002/diff/1/content/browser/accessibility/browser_accessibility_gtk.cc#newcode41 content/browser/accessibility/browser_accessibility_gtk.cc:41: return 0; On 2013/07/29 22:23:09, aboxhall wrote: > Why ...
7 years, 4 months ago (2013-07-29 22:34:27 UTC) #3
aboxhall
lgtm
7 years, 4 months ago (2013-07-29 22:47:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/21148002/22001
7 years, 4 months ago (2013-07-30 21:30:15 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-07-30 22:34:39 UTC) #6
dmazzoni
7 years, 4 months ago (2013-07-31 15:56:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r214752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698