Shrink chrome_elf.dll by switching source_sets to static_library

Shrink chrome_elf.dll by switching source_sets to static_library

Investigation of why official chrome_elf.dll builds were 86,016 bytes
larger on gn than gyp showed that encryption functions such as
aesni_cbc_encrypt were being pulled in. Deleting the implementations
of these functions from the .asm file caused no errors which proved that
the functions weren't being referenced, they just weren't being
discarded. Changing the yasm_assemble template to use static_library
fixed that and made the file sizes identical.

Comparison of the dia2dump -p output after that change showed there were
still two extra symbols in the gn builds:
  class breakpad::CrashKeysWin * breakpad::CrashKeysWin::keeper_
  __aullrem(__aullrem)

keeper_ is a global variable - those are harder to discard, even with
/Gw - but making its source file part of a static_library fixed it.

link /verbose showed that __aullrem is pulled in by an object file that
is then discarded but I decided that following that trail wasn't worth
it. The file sizes are identical and dumpbin /headers shows that the
.text sections virtual size is just 96 bytes larger in the gn case.

Additional changes of source set to static_library may address the
remaining diffs, but they are not large enough to matter.

TL;DR The linker tries to discard unreferenced symbols but it is not
perfect at doing it, even with /Gw and /Gy. Assembly functions may be
difficult also. Use source_set with care.

BUG=624274
Committed: https://crrev.com/0ab90cb1edf8f08f1fa5d2551aa21cac225163cf
Cr-Commit-Position: refs/heads/master@{#403480}

[brucedawson, 2016-06-30 21:40:51]

brucedawson@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2016-07-01 17:47:45]

lgtm

[brucedawson, 2016-07-01 17:50:58]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-07-01 17:51:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 17:56:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 17:56:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 17:57:44]

Description was changed from

==========
Shrink chrome_elf.dll by switching source_sets to static_library

Investigation of why official chrome_elf.dll builds were 86,016 bytes
larger on gn than gyp showed that encryption functions such as
aesni_cbc_encrypt were being pulled in. Deleting the implementations
of these functions from the .asm file caused no errors which proved that
the functions weren't being referenced, they just weren't being
discarded. Changing the yasm_assemble template to use static_library
fixed that and made the file sizes identical.

Comparison of the dia2dump -p output after that change showed there were
still two extra symbols in the gn builds:
  class breakpad::CrashKeysWin * breakpad::CrashKeysWin::keeper_
  __aullrem(__aullrem)

keeper_ is a global variable - those are harder to discard, even with
/Gw - but making its source file part of a static_library fixed it.

link /verbose showed that __aullrem is pulled in by an object file that
is then discarded but I decided that following that trail wasn't worth
it. The file sizes are identical and dumpbin /headers shows that the
.text sections virtual size is just 96 bytes larger in the gn case.

Additional changes of source set to static_library may address the
remaining diffs, but they are not large enough to matter.

TL;DR The linker tries to discard unreferenced symbols but it is not
perfect at doing it, even with /Gw and /Gy. Assembly functions may be
difficult also. Use source_set with care.

BUG=624274
==========

to

==========
Shrink chrome_elf.dll by switching source_sets to static_library

Investigation of why official chrome_elf.dll builds were 86,016 bytes
larger on gn than gyp showed that encryption functions such as
aesni_cbc_encrypt were being pulled in. Deleting the implementations
of these functions from the .asm file caused no errors which proved that
the functions weren't being referenced, they just weren't being
discarded. Changing the yasm_assemble template to use static_library
fixed that and made the file sizes identical.

Comparison of the dia2dump -p output after that change showed there were
still two extra symbols in the gn builds:
  class breakpad::CrashKeysWin * breakpad::CrashKeysWin::keeper_
  __aullrem(__aullrem)

keeper_ is a global variable - those are harder to discard, even with
/Gw - but making its source file part of a static_library fixed it.

link /verbose showed that __aullrem is pulled in by an object file that
is then discarded but I decided that following that trail wasn't worth
it. The file sizes are identical and dumpbin /headers shows that the
.text sections virtual size is just 96 bytes larger in the gn case.

Additional changes of source set to static_library may address the
remaining diffs, but they are not large enough to matter.

TL;DR The linker tries to discard unreferenced symbols but it is not
perfect at doing it, even with /Gw and /Gy. Assembly functions may be
difficult also. Use source_set with care.

BUG=624274

Committed: https://crrev.com/0ab90cb1edf8f08f1fa5d2551aa21cac225163cf
Cr-Commit-Position: refs/heads/master@{#403480}
==========

[commit-bot: I haz the power, 2016-07-01 17:57:45]

Patchset 1 (id:??) landed as
https://crrev.com/0ab90cb1edf8f08f1fa5d2551aa21cac225163cf
Cr-Commit-Position: refs/heads/master@{#403480}