Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2114743002: Reland of Add crash instrumentation for crbug.com/621147 (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Add crash instrumentation for crbug.com/621147 (patchset #1 id:1 of https://codereview.chromium.org/2118493002/ ) Reason for revert: By request from ishell, plan is to leave this in master for awhile longer Original issue's description: > Revert of Add crash instrumentation for crbug.com/621147 (patchset #5 id:80001 of https://codereview.chromium.org/2100313002/ ) > > Reason for revert: > Instrumentation not needed on master branch > > Original issue's description: > > Add crash instrumentation for crbug.com/621147 > > > > BUG=chromium:621147 > > LOG=N > > R=ishell@chromium.org,cbruni@chromium.org > > > > Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8 > > Cr-Commit-Position: refs/heads/master@{#37328} > > TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:621147, chromium:624764 > > Committed: https://crrev.com/b324850900e531ccee03f1712333f13dfcf15427 > Cr-Commit-Position: refs/heads/master@{#37456} TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621147, chromium:624764 Committed: https://crrev.com/6e9832583c23f10fb2e66b6bfeacc4605ef0c082 Cr-Commit-Position: refs/heads/master@{#37458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/ic/ic.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Created Reland of Add crash instrumentation for crbug.com/621147
4 years, 5 months ago (2016-06-30 17:50:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114743002/1
4 years, 5 months ago (2016-06-30 17:51:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:51:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e9832583c23f10fb2e66b6bfeacc4605ef0c082 Cr-Commit-Position: refs/heads/master@{#37458}
4 years, 5 months ago (2016-06-30 17:53:54 UTC) #6
Jakob Kummerow
4 years, 5 months ago (2016-07-06 12:34:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2127813002/ by jkummerow@chromium.org.

The reason for reverting is: Bug found and fixed:
crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e

Instrumentation no longer needed..

Powered by Google App Engine
This is Rietveld 408576698