Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 211473005: Remove unused createContentDecryptionModule() code. (Closed)

Created:
6 years, 9 months ago by jrummell
Modified:
6 years, 9 months ago
Reviewers:
jamesr, ddorwin
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unused createContentDecryptionModule() code. BUG=250049 TEST=encrypted media layout and browser tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M content/renderer/media/webcontentdecryptionmodule_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webcontentdecryptionmodule_impl.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jrummell
PTAL.
6 years, 9 months ago (2014-03-25 21:44:18 UTC) #1
ddorwin
LGTM once the TEST= line is updated.
6 years, 9 months ago (2014-03-25 22:00:21 UTC) #2
jrummell
+jamesr@ for OWNERS review of content/renderer/renderer_webkitplatformsupport_impl.*
6 years, 9 months ago (2014-03-25 22:07:08 UTC) #3
jamesr
lgtm
6 years, 9 months ago (2014-03-26 01:00:54 UTC) #4
ddorwin
The CQ bit was checked by ddorwin@chromium.org
6 years, 9 months ago (2014-03-26 01:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/211473005/1
6 years, 9 months ago (2014-03-26 01:16:33 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 05:08:34 UTC) #7
Message was sent while issue was closed.
Change committed as 259501

Powered by Google App Engine
This is Rietveld 408576698