Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2114723002: Fix a crash where we tried to update match we didn't have. (Closed)

Created:
4 years, 5 months ago by Maria
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash where we tried to update match we didn't have. In this case the match exists in native, but not in Java. Ensure we don't throw in this case. BUG=624703 Committed: https://crrev.com/c4dd1db65bcdd79498a0fda4e1a37cdf651e02fa Cr-Commit-Position: refs/heads/master@{#403246}

Patch Set 1 #

Patch Set 2 : Update how we skip the check #

Patch Set 3 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 2 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Maria
4 years, 5 months ago (2016-06-30 16:53:44 UTC) #2
Maria
On 2016/06/30 16:53:44, Maria wrote: PTAL
4 years, 5 months ago (2016-06-30 17:29:27 UTC) #3
Ted C
lgtm, but update the commit description
4 years, 5 months ago (2016-06-30 17:30:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114723002/40001
4 years, 5 months ago (2016-06-30 18:38:31 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 19:23:06 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:25:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4dd1db65bcdd79498a0fda4e1a37cdf651e02fa
Cr-Commit-Position: refs/heads/master@{#403246}

Powered by Google App Engine
This is Rietveld 408576698