Remove GrTInstanceBatch

Remove GrTInstanceBatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003

Committed: https://skia.googlesource.com/skia/+/08d141534cb24a491edbf5db31cdc7b966ec8d72

[bsalomon, 2016-06-30 18:22:34]

Description was changed from

==========
djsfkdsjkfld

BUG=skia:
==========

to

==========
djsfkdsjkfld

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003
==========

[bsalomon, 2016-06-30 19:07:09]

Description was changed from

==========
djsfkdsjkfld

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003
==========

to

==========
Remove GrTInstanceBatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003
==========

[bsalomon, 2016-06-30 19:07:09]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-06-30 19:08:57]

This is about as minimal as I could do this. I kept all the static functions
that were used by GrTInstanceBatch. I'll cleanup the batch subclasses in
subsequent changes.

[robertphillips, 2016-06-30 19:22:16]

lgtm but I would also support killing off the static methods in this CL too

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
File src/gpu/batches/GrAAFillRectBatch.cpp (right):

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:202: 
rm Name too ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:219:
color->setKnownFourComponents(fGeoData[0].fColor);
rm InitInvariantOutput ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:232: const Geometry& geo = fGeoData[0];
fold this in ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:237: const Geometry& geo =
fGeoData.back();
this too ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:324: i * kVertsPerInstance * vertexStride;
rm Tesselate ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:373: 
same here

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:390:
color->setKnownFourComponents(fGeoData[0].fColor);
rm InitInvariantOutput ?

https://codereview.chromium.org/2114663003/diff/20001/src/gpu/batches/GrAAFil...
src/gpu/batches/GrAAFillRectBatch.cpp:493: i * kVertsPerInstance * vertexStride;
rm Tesselate here too ?

[bsalomon, 2016-06-30 19:24:43]

I'd prefer to land this and then iterate on moving improvements.

[bsalomon, 2016-06-30 19:24:56]

On 2016/06/30 19:24:43, bsalomon wrote:
> I'd prefer to land this and then iterate on moving improvements.

making

[bsalomon, 2016-06-30 19:25:07]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-30 19:25:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 19:45:20]

Description was changed from

==========
Remove GrTInstanceBatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003
==========

to

==========
Remove GrTInstanceBatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114663003

Committed:
https://skia.googlesource.com/skia/+/08d141534cb24a491edbf5db31cdc7b966ec8d72
==========

[commit-bot: I haz the power, 2016-06-30 19:45:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08d141534cb24a491edbf5db31cdc7b966ec8d72