Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2114623002: Switch from setTintList() to setColorFilter() for pre-L compatibility. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 5 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch from setTintList() to setColorFilter() for pre-L compatibility. setTintList() is an API 21 method. setColorFilter() with the right parameters does the same thing. BUG=624690 TBR=finnur@chromium.org Committed: https://crrev.com/4c324b669644926eaee740e3a49506ab4330b4a8 Cr-Commit-Position: refs/heads/master@{#403149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114623002/1
4 years, 5 months ago (2016-06-30 10:17:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 11:58:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c324b669644926eaee740e3a49506ab4330b4a8 Cr-Commit-Position: refs/heads/master@{#403149}
4 years, 5 months ago (2016-06-30 11:59:56 UTC) #6
Finnur
4 years, 5 months ago (2016-06-30 21:02:28 UTC) #7
Message was sent while issue was closed.
LGTM. 

Sorry for the late response, I've been going through an office move and I have
very limited Internet connectivity -- might continue tomorrow.

Powered by Google App Engine
This is Rietveld 408576698