Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2114613002: [intrinsics] Drop the now obsolete %_DoubleHi and %_DoubleLo intrinsics. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Drop the now obsolete %_DoubleHi and %_DoubleLo intrinsics. These are no longer used, except in tests that test these intrinsics. R=yangguo@chromium.org Committed: https://crrev.com/bbc44c2696598663d9af02eca0cecb8218cd646a Cr-Commit-Position: refs/heads/master@{#37432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -497 lines) Patch
M src/compiler/typer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D test/mjsunit/asm/double-hi.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/mjsunit/asm/double-lo.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/mjsunit/double-intrinsics.js View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-30 09:52:16 UTC) #1
Benedikt Meurer
Hey Yang, Some dead code cleanup. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-06-30 09:54:15 UTC) #2
Yang
On 2016/06/30 09:54:15, Benedikt Meurer wrote: > Hey Yang, > > Some dead code cleanup. ...
4 years, 5 months ago (2016-06-30 09:58:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114613002/1
4 years, 5 months ago (2016-06-30 10:17:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 10:21:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 10:21:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbc44c2696598663d9af02eca0cecb8218cd646a
Cr-Commit-Position: refs/heads/master@{#37432}

Powered by Google App Engine
This is Rietveld 408576698