Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2114553002: X87: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. port 257336d26a9b4f8efad872d3166a5ac3742e9adc (r37297) original commit message: Replaces ArchDefault method with Crankshaft and Turbofan getters. Eliminates IsAllocated method on Register, FloatRegister, DoubleRegister. Eliminates ToString method too. Changes call sites to access appropriate arch default RegisterConfiguration. BUG= Committed: https://crrev.com/21550e025ca6ff3a5779350148da037281dc2784 Cr-Commit-Position: refs/heads/master@{#37413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/code-stubs-x87.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-30 04:22:27 UTC) #2
bbudge
lgtm
4 years, 5 months ago (2016-06-30 05:01:49 UTC) #3
Weiliang
lgtm
4 years, 5 months ago (2016-06-30 05:48:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114553002/1
4 years, 5 months ago (2016-06-30 05:53:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 06:23:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:25:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21550e025ca6ff3a5779350148da037281dc2784
Cr-Commit-Position: refs/heads/master@{#37413}

Powered by Google App Engine
This is Rietveld 408576698