chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java - Issue 2114513002: Fade theme color in tab switcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Issue 2114513002: Fade theme color in tab switcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments & fix coloring invisible LayoutTab Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

index 669d587bc066cae645ea0ac4f46e26d40274152b..422b1c895d72790bb4382152716675a9c77c5c39 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

@@ -84,7 +84,6 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar,

}

- private static final int BRAND_COLOR_TRANSITION_DURATION_MS = 250;

private static final int TITLE_ANIM_DELAY_MS = 800;

private static final int STATE_DOMAIN_ONLY = 0;

private static final int STATE_TITLE_ONLY = 1;

@@ -530,7 +529,7 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar,

if (background.getColor() == finalColor) return;

mBrandColorTransitionAnimation = ValueAnimator.ofFloat(0, 1)

- .setDuration(BRAND_COLOR_TRANSITION_DURATION_MS);

+ .setDuration(ToolbarPhone.THEME_COLOR_TRANSITION_DURATION);

mBrandColorTransitionAnimation.setInterpolator(BakedBezierInterpolator.TRANSFORM_CURVE);

mBrandColorTransitionAnimation.addUpdateListener(new AnimatorUpdateListener() {

@Override