chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java - Issue 2114513002: Fade theme color in tab switcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 2114513002: Fade theme color in tab switcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments & fix coloring invisible LayoutTab Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

index f10e88f85414572ee9caeadaf3a9617ffc333856..ac0a0931411ff22bbdcebaa4eb65b795b1c85f66 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

@@ -262,10 +262,11 @@ public class LayoutManagerDocument extends LayoutManager

int themeColor = tab.getThemeColor();

boolean canUseLiveTexture =

tab.getContentViewCore() != null && !tab.isShowingSadTab() && !isNativePage;

- layoutTab.initFromHost(tab.getBackgroundColor(), tab.shouldStall(), canUseLiveTexture,

- themeColor, ColorUtils.getTextBoxColorForToolbarBackground(

+ boolean needsUpdate = layoutTab.initFromHost(tab.getBackgroundColor(), tab.shouldStall(),

+ canUseLiveTexture, themeColor, ColorUtils.getTextBoxColorForToolbarBackground(

mContext.getResources(), tab, themeColor),

ColorUtils.getTextBoxAlphaForToolbarBackground(tab));

+ if (needsUpdate) requestUpdate();

mHost.requestRender();

}