arc: Notify the user on fatal opt-in flow errors

arc: Notify the user on fatal opt-in flow errors

If ARC has a fatal error during first initialization, the user will
never be notified. It might also cause a case where ARC would be stopped
and started infinitely without giving the user a chance to stop it. This
change adds some logic to stop automatically retrying to start ARC and
let the user decide to do so instead.

BUG=b/29833836
TEST=Kill ARC mid-initialization, "Service unavailable" is shown

Committed: https://crrev.com/bbe66f3c030c62d2e07d24082817d9f68da2a6d1
Cr-Commit-Position: refs/heads/master@{#403231}

[Luis Héctor Chávez, 2016-06-29 23:37:49]

lhchavez@chromium.org changed reviewers:
+ khmel@chromium.org, yusukes@chromium.org

[Luis Héctor Chávez, 2016-06-29 23:37:50]

PTAL

https://codereview.chromium.org/2114463002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2114463002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:246: waiting_for_reply_ = false;
If adding this flag is undesirable, all the places where I touch it,
|sign_in_time_| is also used and could be removed if I reset |sign_in_time_|
near the two places where I reset |waiting_for_reply_|.

I didn't want to conflate both, so I personally prefer to keep them separate.

[khmel, 2016-06-29 23:39:27]

lgtm

[Yusuke Sato, 2016-06-30 17:50:58]

lgtm

[Luis Héctor Chávez, 2016-06-30 18:00:59]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:02:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:39:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 18:39:55]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 18:41:18]

Description was changed from

==========
arc: Notify the user on fatal opt-in flow errors

If ARC has a fatal error during first initialization, the user will
never be notified. It might also cause a case where ARC would be stopped
and started infinitely without giving the user a chance to stop it. This
change adds some logic to stop automatically retrying to start ARC and
let the user decide to do so instead.

BUG=b/29833836
TEST=Kill ARC mid-initialization, "Service unavailable" is shown
==========

to

==========
arc: Notify the user on fatal opt-in flow errors

If ARC has a fatal error during first initialization, the user will
never be notified. It might also cause a case where ARC would be stopped
and started infinitely without giving the user a chance to stop it. This
change adds some logic to stop automatically retrying to start ARC and
let the user decide to do so instead.

BUG=b/29833836
TEST=Kill ARC mid-initialization, "Service unavailable" is shown

Committed: https://crrev.com/bbe66f3c030c62d2e07d24082817d9f68da2a6d1
Cr-Commit-Position: refs/heads/master@{#403231}
==========

[commit-bot: I haz the power, 2016-06-30 18:41:19]

Patchset 1 (id:??) landed as
https://crrev.com/bbe66f3c030c62d2e07d24082817d9f68da2a6d1
Cr-Commit-Position: refs/heads/master@{#403231}