Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/cronet/ios/cronet_environment.cc

Issue 2114453005: [Cronet] Remove FakeCertVerifier on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/ios/cronet_environment.cc
diff --git a/components/cronet/ios/cronet_environment.cc b/components/cronet/ios/cronet_environment.cc
index 01f76f544886ded1261bc760ffa7164065d2274f..bece3b2343ca35dea1fe0008d41e3224dade472c 100644
--- a/components/cronet/ios/cronet_environment.cc
+++ b/components/cronet/ios/cronet_environment.cc
@@ -56,32 +56,6 @@ net::NetworkChangeNotifier* g_network_change_notifier = nullptr;
// MessageLoop on the main thread.
base::MessageLoop* g_main_message_loop = nullptr;
-#if USE_FAKE_CERT_VERIFIER
-// TODO(mef): Remove this after GRPC testing is done.
-class FakeCertVerifier : public net::CertVerifier {
- public:
- FakeCertVerifier() {}
-
- ~FakeCertVerifier() override {}
-
- // CertVerifier implementation
- int Verify(net::X509Certificate* cert,
- const std::string& hostname,
- const std::string& ocsp_response,
- int flags,
- net::CRLSet* crl_set,
- net::CertVerifyResult* verify_result,
- const net::CompletionCallback& callback,
- std::unique_ptr<Request>* out_req,
- const net::BoundNetLog& net_log) override {
- // It's all good!
- verify_result->verified_cert = cert;
- verify_result->cert_status = MapNetErrorToCertStatus(net::OK);
- return net::OK;
- }
-};
-#endif // USE_FAKE_CERT_VERIFIER
-
} // namespace
namespace cronet {
@@ -213,11 +187,6 @@ CronetEnvironment::CronetEnvironment(const std::string& user_agent_product_name)
net_log_(new net::NetLog) {}
void CronetEnvironment::Start() {
-#if USE_FAKE_CERT_VERIFIER
- // TODO(mef): Remove this and FakeCertVerifier after GRPC testing.
- set_cert_verifier(std::unique_ptr<net::CertVerifier>(new FakeCertVerifier()));
-#endif // USE_FAKE_CERT_VERIFIER
-
// Threads setup.
network_cache_thread_.reset(new base::Thread("Chrome Network Cache Thread"));
network_cache_thread_->StartWithOptions(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698