Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 211443003: Revert of Determine language code and type of format for address. (Closed)

Created:
6 years, 9 months ago by erikchen2
Modified:
6 years, 9 months ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Revert of Determine language code and type of format for address. (https://codereview.chromium.org/208243005/) Reason for revert: compile error https://code.google.com/p/libaddressinput/issues/detail?id=5 Original issue's description: > Determine language code and type of format for address. > > BuildComponents() in address_ui.h should take the UI language and > determine the following two questions. > > (1) Whether to show UI components based on local or latinized address > format. > > If the UI language does not match the default language for the country, > and latinized address format is available, then use the latinized > format. All countries with a latinized address format also have the > default language specified. > > (2) Which language code should be used to format the address after the > user provides it. > > If the UI language is one of the languages supported by the country, > then use the UI language. If the country lists supported languages, none > of which match the UI language, then pick the first supported language. > If the country does not have supported languages (e.g. Antarctica), then > use the UI language for formatting. If using the latinized format and > the UI language is not one of the supported languages, then the > formatting language is [country's default language] + "-latn". > > BUG=354954 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259150 TBR=estade@chromium.org,rouslan@chromium.org NOTREECHECKS=true NOTRY=true BUG=354954 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -771 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/country_combobox_model_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h View 1 chunk +3 lines, -20 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_data.cc View 3 chunks +24 lines, -11 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_ui.cc View 5 chunks +3 lines, -92 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc View 24 chunks +55 lines, -298 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/retriever.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/rule.h View 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/rule.cc View 5 chunks +2 lines, -13 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/time_to_string.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/time_to_string.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_compare.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_compare.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_split.h View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_split.cc View 1 chunk +37 lines, -0 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_util.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_util.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_data_test.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc View 3 chunks +2 lines, -51 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/retriever_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/libaddressinput/chromium/cpp/test/util/string_split_unittest.cc View 1 chunk +89 lines, -0 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/string_util_test.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen2
Created Revert of Determine language code and type of format for address.
6 years, 9 months ago (2014-03-25 17:10:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@google.com/211443003/1
6 years, 9 months ago (2014-03-25 17:11:11 UTC) #2
commit-bot: I haz the power
Change committed as 259239
6 years, 9 months ago (2014-03-25 17:12:40 UTC) #3
please use gerrit instead
6 years, 9 months ago (2014-03-25 17:19:32 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698